Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added animation clip parsing and writer callbacks #592

Closed
wants to merge 0 commits into from

Conversation

lasalvavida
Copy link
Contributor

Resolves #565 and enables multiple animations support in COLLADA2GLTF: KhronosGroup/COLLADA2GLTF#130.

@CLAassistant
Copy link

CLAassistant commented Oct 3, 2018

CLA assistant check
All committers have signed the CLA.

@Fl4reBot
Copy link

Fl4reBot commented Oct 3, 2018

FAILURE: exercise-opencollada-pull-request build #153

  • COLLADA-MAX-PC-PULL-REQUEST build #456 with result FAILURE.
  • COLLADA-MAYA-PC-PULL-REQUEST build #451 with result FAILURE.
  • Maya-2015_2017-mac-pull-request build #440 with result FAILURE.
  • openCOLLADA-mac-pull-request build #450 with result FAILURE.
  • openCOLLADA-pc-pull-request build #445 with result FAILURE.
  • openCOLLADA-ubuntu-pull-request build #339 with result FAILURE.

Pull Requests:

@RemiArnaud
Copy link
Contributor

In file included from /var/lib/jenkins/workspace/openCOLLADA-ubuntu-pull-request/COLLADAValidator/src/../include/Writer.h:5:0,
from /var/lib/jenkins/workspace/openCOLLADA-ubuntu-pull-request/COLLADAValidator/src/main.cpp:1:
/var/lib/jenkins/workspace/openCOLLADA-ubuntu-pull-request/COLLADAFramework/include/COLLADAFWIWriter.h:114:42: error: ‘AnimationClip’ does not name a type
virtual bool writeAnimationClip( const AnimationClip* animationClip ) = 0;
^
/var/lib/jenkins/workspace/openCOLLADA-ubuntu-pull-request/COLLADAFramework/include/COLLADAFWIWriter.h:114:57: error: ISO C++ forbids declaration of ‘animationClip’ with no type [-fpermissive]
virtual bool writeAnimationClip( const AnimationClip* animationClip ) = 0;
^
/var/lib/jenkins/workspace/openCOLLADA-ubuntu-pull-request/COLLADAValidator/src/main.cpp: In function ‘void parse(char*, ValidationErrorHandler&)’:
/var/lib/jenkins/workspace/openCOLLADA-ubuntu-pull-request/COLLADAValidator/src/main.cpp:33:11: error: cannot declare variable ‘writer’ to be of abstract type ‘Writer’
::Writer writer;
^
In file included from /var/lib/jenkins/workspace/openCOLLADA-ubuntu-pull-request/COLLADAValidator/src/main.cpp:1:0:
/var/lib/jenkins/workspace/openCOLLADA-ubuntu-pull-request/COLLADAValidator/src/../include/Writer.h:13:7: note: because the following virtual functions are pure within ‘Writer’:
class Writer : public COLLADAFW::IWriter
^
In file included from /var/lib/jenkins/workspace/openCOLLADA-ubuntu-pull-request/COLLADAValidator/src/../include/Writer.h:5:0,
from /var/lib/jenkins/workspace/openCOLLADA-ubuntu-pull-request/COLLADAValidator/src/main.cpp:1:
/var/lib/jenkins/workspace/openCOLLADA-ubuntu-pull-request/COLLADAFramework/include/COLLADAFWIWriter.h:114:16: note: virtual bool COLLADAFW::IWriter::writeAnimationClip(const int*)
virtual bool writeAnimationClip( const AnimationClip* animationClip ) = 0;

@lasalvavida
Copy link
Contributor Author

lasalvavida commented Oct 3, 2018

Thanks @RemiArnaud. Will fix.

@Fl4reBot
Copy link

Fl4reBot commented Oct 9, 2018

FAILURE: exercise-opencollada-pull-request build #154

  • COLLADA-MAX-PC-PULL-REQUEST build #457 with result FAILURE.
  • COLLADA-MAYA-PC-PULL-REQUEST build #452 with result FAILURE.
  • Maya-2015_2017-mac-pull-request build #441 with result FAILURE.
  • openCOLLADA-mac-pull-request build #451 with result FAILURE.
  • openCOLLADA-pc-pull-request build #446 with result FAILURE.
  • openCOLLADA-ubuntu-pull-request build #340 with result FAILURE.

Pull Requests:

@Fl4reBot
Copy link

FAILURE: exercise-opencollada-pull-request build #155

  • COLLADA-MAX-PC-PULL-REQUEST build #458 with result FAILURE.
  • COLLADA-MAYA-PC-PULL-REQUEST build #453 with result FAILURE.
  • Maya-2015_2017-mac-pull-request build #442 with result FAILURE.
  • openCOLLADA-mac-pull-request build #452 with result SUCCESS. Artifacts: OpenCOLLADA Mac
  • openCOLLADA-pc-pull-request build #447 with result SUCCESS. Artifacts: OpenCOLLADA Win
  • openCOLLADA-ubuntu-pull-request build #341 with result SUCCESS. Artifacts: OpenCOLLADA Ubuntu

Pull Requests:

@RemiArnaud
Copy link
Contributor

RemiArnaud commented Oct 10, 2018

..\src\COLLADAMaxColladaImporter.cpp(127): error C2259: 'COLLADAMax::DocumentImporter' : cannot instantiate abstract class [e:\git\workspace\COLLADA-MAX-PC-PULL-REQUEST\COLLADAMax\scripts\COLLADAMax.vcxproj]
due to following members:
'bool COLLADAFW::IWriter::writeAnimationClip(const COLLADAFW::AnimationClip *)' : is abstract
....\COLLADAFramework\include\COLLADAFWIWriter.h(115) : see declaration of 'COLLADAFW::IWriter::writeAnimationClip'

(was the previous build) issue

@Fl4reBot
Copy link

FAILURE: exercise-opencollada-pull-request build #156

  • COLLADA-MAX-PC-PULL-REQUEST build #459 with result FAILURE.
  • COLLADA-MAYA-PC-PULL-REQUEST build #454 with result FAILURE.
  • Maya-2015_2017-mac-pull-request build #443 with result FAILURE.
  • openCOLLADA-mac-pull-request build #453 with result SUCCESS. Artifacts: OpenCOLLADA Mac
  • openCOLLADA-pc-pull-request build #448 with result SUCCESS. Artifacts: OpenCOLLADA Win
  • openCOLLADA-ubuntu-pull-request build #342 with result SUCCESS. Artifacts: OpenCOLLADA Ubuntu

Pull Requests:

@RemiArnaud
Copy link
Contributor

COLLADA-MAX:

COLLADASaxFrameworkLoader.lib(COLLADASaxFWLRootParser14.obj) : error LNK2001: unresolved external symbol "public: __cdecl COLLADASaxFWL::LibraryAnimationClipsLoader::LibraryAnimationClipsLoader(class COLLADASaxFWL::IFilePartLoader *)" (??0LibraryAnimationClipsLoader@COLLADASaxFWL@@qeaa@PEAVIFilePartLoader@1@@z) [e:\git\workspace\COLLADA-MAX-PC-PULL-REQUEST\COLLADAMax\scripts\COLLADAMax.vcxproj]
COLLADASaxFrameworkLoader.lib(COLLADASaxFWLRootParser14.obj) : error LNK2001: unresolved external symbol "public: virtual bool __cdecl COLLADASaxFWL::LibraryAnimationClipsLoader14::end__library_animation_clips(void)" (?end__library_animation_clips@LibraryAnimationClipsLoader14@COLLADASaxFWL@@UEAA_NXZ) [e:\git\workspace\COLLADA-MAX-PC-PULL-REQUEST\COLLADAMax\scripts\COLLADAMax.vcxproj]
COLLADASaxFrameworkLoader.lib(COLLADASaxFWLRootParser14.obj) : error LNK2001: unresolved external symbol "public: virtual bool __cdecl COLLADASaxFWL::LibraryAnimationClipsLoader14::begin__animation_clip(struct COLLADASaxFWL14::animation_clip__AttributeData const &)" (?begin__animation_clip@LibraryAnimationClipsLoader14@COLLADASaxFWL@@UEAA_NAEBUanimation_clip__AttributeData@COLLADASaxFWL14@@@z) [e:\git\workspace\COLLADA-MAX-PC-PULL-REQUEST\COLLADAMax\scripts\COLLADAMax.vcxproj]
COLLADASaxFrameworkLoader.lib(COLLADASaxFWLRootParser14.obj) : error LNK2001: unresolved external symbol "public: virtual bool __cdecl COLLADASaxFWL::LibraryAnimationClipsLoader14::end__animation_clip(void)" (?end__animation_clip@LibraryAnimationClipsLoader14@COLLADASaxFWL@@UEAA_NXZ) [e:\git\workspace\COLLADA-MAX-PC-PULL-REQUEST\COLLADAMax\scripts\COLLADAMax.vcxproj]
COLLADASaxFrameworkLoader.lib(COLLADASaxFWLRootParser14.obj) : error LNK2001: unresolved external symbol "public: virtual bool __cdecl COLLADASaxFWL::LibraryAnimationClipsLoader14::begin__instance_animation(struct COLLADASaxFWL14::instance_animation__AttributeData const &)" (?begin__instance_animation@LibraryAnimationClipsLoader14@COLLADASaxFWL@@UEAA_NAEBUinstance_animation__AttributeData@COLLADASaxFWL14@@@z) [e:\git\workspace\COLLADA-MAX-PC-PULL-REQUEST\COLLADAMax\scripts\COLLADAMax.vcxproj]
COLLADASaxFrameworkLoader.lib(COLLADASaxFWLRootParser14.obj) : error LNK2001: unresolved external symbol "public: virtual bool __cdecl COLLADASaxFWL::LibraryAnimationClipsLoader14::end__instance_animation(void)" (?end__instance_animation@LibraryAnimationClipsLoader14@COLLADASaxFWL@@UEAA_NXZ) [e:\git\workspace\COLLADA-MAX-PC-PULL-REQUEST\COLLADAMax\scripts\COLLADAMax.vcxproj]
COLLADASaxFrameworkLoader.lib(COLLADASaxFWLRootParser15.obj) : error LNK2001: unresolved external symbol "public: virtual bool __cdecl COLLADASaxFWL::LibraryAnimationClipsLoader15::end__library_animation_clips(void)" (?end__library_animation_clips@LibraryAnimationClipsLoader15@COLLADASaxFWL@@UEAA_NXZ) [e:\git\workspace\COLLADA-MAX-PC-PULL-REQUEST\COLLADAMax\scripts\COLLADAMax.vcxproj]
COLLADASaxFrameworkLoader.lib(COLLADASaxFWLRootParser15.obj) : error LNK2001: unresolved external symbol "public: virtual bool __cdecl COLLADASaxFWL::LibraryAnimationClipsLoader15::begin__animation_clip(struct COLLADASaxFWL15::animation_clip__AttributeData const &)" (?begin__animation_clip@LibraryAnimationClipsLoader15@COLLADASaxFWL@@UEAA_NAEBUanimation_clip__AttributeData@COLLADASaxFWL15@@@z) [e:\git\workspace\COLLADA-MAX-PC-PULL-REQUEST\COLLADAMax\scripts\COLLADAMax.vcxproj]
COLLADASaxFrameworkLoader.lib(COLLADASaxFWLRootParser15.obj) : error LNK2001: unresolved external symbol "public: virtual bool __cdecl COLLADASaxFWL::LibraryAnimationClipsLoader15::end__animation_clip(void)" (?end__animation_clip@LibraryAnimationClipsLoader15@COLLADASaxFWL@@UEAA_NXZ) [e:\git\workspace\COLLADA-MAX-PC-PULL-REQUEST\COLLADAMax\scripts\COLLADAMax.vcxproj]
COLLADASaxFrameworkLoader.lib(COLLADASaxFWLRootParser15.obj) : error LNK2001: unresolved external symbol "public: virtual bool __cdecl COLLADASaxFWL::LibraryAnimationClipsLoader15::begin__instance_animation(struct COLLADASaxFWL15::instance_animation__AttributeData const &)" (?begin__instance_animation@LibraryAnimationClipsLoader15@COLLADASaxFWL@@UEAA_NAEBUinstance_animation__AttributeData@COLLADASaxFWL15@@@z) [e:\git\workspace\COLLADA-MAX-PC-PULL-REQUEST\COLLADAMax\scripts\COLLADAMax.vcxproj]
COLLADASaxFrameworkLoader.lib(COLLADASaxFWLRootParser15.obj) : error LNK2001: unresolved external symbol "public: virtual bool __cdecl COLLADASaxFWL::LibraryAnimationClipsLoader15::end__instance_animation(void)" (?end__instance_animation@LibraryAnimationClipsLoader15@COLLADASaxFWL@@UEAA_NXZ) [e:\git\workspace\COLLADA-MAX-PC-PULL-REQUEST\COLLADAMax\scripts\COLLADAMax.vcxproj]
..\bin\win\x64\Release_Max2011\COLLADAMaxNew.dle : fatal error LNK1120: 11 unresolved externals [e:\git\workspace\COLLADA-MAX-PC-PULL-REQUEST\COLLADAMax\scripts\COLLADAMax.vcxproj]

COLLADA-MAYA:
2>COLLADASaxFrameworkLoader.lib(COLLADASaxFWLRootParser14.obj) : error LNK2001: unresolved external symbol "public: __cdecl COLLADASaxFWL::LibraryAnimationClipsLoader::LibraryAnimationClipsLoader(class COLLADASaxFWL::IFilePartLoader *)" (??0LibraryAnimationClipsLoader@COLLADASaxFWL@@qeaa@PEAVIFilePartLoader@1@@z) [e:\git\workspace\COLLADA-MAYA-PC-PULL-REQUEST\COLLADAMaya\scripts\COLLADAMaya.vcxproj]
2>COLLADASaxFrameworkLoader.lib(COLLADASaxFWLRootParser14.obj) : error LNK2001: unresolved external symbol "public: virtual bool __cdecl COLLADASaxFWL::LibraryAnimationClipsLoader14::end__library_animation_clips(void)" (?end__library_animation_clips@LibraryAnimationClipsLoader14@COLLADASaxFWL@@UEAA_NXZ) [e:\git\workspace\COLLADA-MAYA-PC-PULL-REQUEST\COLLADAMaya\scripts\COLLADAMaya.vcxproj]
2>COLLADASaxFrameworkLoader.lib(COLLADASaxFWLRootParser14.obj) : error LNK2001: unresolved external symbol "public: virtual bool __cdecl COLLADASaxFWL::LibraryAnimationClipsLoader14::begin__animation_clip(struct COLLADASaxFWL14::animation_clip__AttributeData const &)" (?begin__animation_clip@LibraryAnimationClipsLoader14@COLLADASaxFWL@@UEAA_NAEBUanimation_clip__AttributeData@COLLADASaxFWL14@@@z) [e:\git\workspace\COLLADA-MAYA-PC-PULL-REQUEST\COLLADAMaya\scripts\COLLADAMaya.vcxproj]
2>COLLADASaxFrameworkLoader.lib(COLLADASaxFWLRootParser14.obj) : error LNK2001: unresolved external symbol "public: virtual bool __cdecl COLLADASaxFWL::LibraryAnimationClipsLoader14::end__animation_clip(void)" (?end__animation_clip@LibraryAnimationClipsLoader14@COLLADASaxFWL@@UEAA_NXZ) [e:\git\workspace\COLLADA-MAYA-PC-PULL-REQUEST\COLLADAMaya\scripts\COLLADAMaya.vcxproj]
2>COLLADASaxFrameworkLoader.lib(COLLADASaxFWLRootParser14.obj) : error LNK2001: unresolved external symbol "public: virtual bool __cdecl COLLADASaxFWL::LibraryAnimationClipsLoader14::begin__instance_animation(struct COLLADASaxFWL14::instance_animation__AttributeData const &)" (?begin__instance_animation@LibraryAnimationClipsLoader14@COLLADASaxFWL@@UEAA_NAEBUinstance_animation__AttributeData@COLLADASaxFWL14@@@z) [e:\git\workspace\COLLADA-MAYA-PC-PULL-REQUEST\COLLADAMaya\scripts\COLLADAMaya.vcxproj]
2>COLLADASaxFrameworkLoader.lib(COLLADASaxFWLRootParser14.obj) : error LNK2001: unresolved external symbol "public: virtual bool __cdecl COLLADASaxFWL::LibraryAnimationClipsLoader14::end__instance_animation(void)" (?end__instance_animation@LibraryAnimationClipsLoader14@COLLADASaxFWL@@UEAA_NXZ) [e:\git\workspace\COLLADA-MAYA-PC-PULL-REQUEST\COLLADAMaya\scripts\COLLADAMaya.vcxproj]
2>COLLADASaxFrameworkLoader.lib(COLLADASaxFWLRootParser15.obj) : error LNK2001: unresolved external symbol "public: virtual bool __cdecl COLLADASaxFWL::LibraryAnimationClipsLoader15::end__library_animation_clips(void)" (?end__library_animation_clips@LibraryAnimationClipsLoader15@COLLADASaxFWL@@UEAA_NXZ) [e:\git\workspace\COLLADA-MAYA-PC-PULL-REQUEST\COLLADAMaya\scripts\COLLADAMaya.vcxproj]
2>COLLADASaxFrameworkLoader.lib(COLLADASaxFWLRootParser15.obj) : error LNK2001: unresolved external symbol "public: virtual bool __cdecl COLLADASaxFWL::LibraryAnimationClipsLoader15::begin__animation_clip(struct COLLADASaxFWL15::animation_clip__AttributeData const &)" (?begin__animation_clip@LibraryAnimationClipsLoader15@COLLADASaxFWL@@UEAA_NAEBUanimation_clip__AttributeData@COLLADASaxFWL15@@@z) [e:\git\workspace\COLLADA-MAYA-PC-PULL-REQUEST\COLLADAMaya\scripts\COLLADAMaya.vcxproj]
2>COLLADASaxFrameworkLoader.lib(COLLADASaxFWLRootParser15.obj) : error LNK2001: unresolved external symbol "public: virtual bool __cdecl COLLADASaxFWL::LibraryAnimationClipsLoader15::end__animation_clip(void)" (?end__animation_clip@LibraryAnimationClipsLoader15@COLLADASaxFWL@@UEAA_NXZ) [e:\git\workspace\COLLADA-MAYA-PC-PULL-REQUEST\COLLADAMaya\scripts\COLLADAMaya.vcxproj]
2>COLLADASaxFrameworkLoader.lib(COLLADASaxFWLRootParser15.obj) : error LNK2001: unresolved external symbol "public: virtual bool __cdecl COLLADASaxFWL::LibraryAnimationClipsLoader15::begin__instance_animation(struct COLLADASaxFWL15::instance_animation__AttributeData const &)" (?begin__instance_animation@LibraryAnimationClipsLoader15@COLLADASaxFWL@@UEAA_NAEBUinstance_animation__AttributeData@COLLADASaxFWL15@@@z) [e:\git\workspace\COLLADA-MAYA-PC-PULL-REQUEST\COLLADAMaya\scripts\COLLADAMaya.vcxproj]
2>COLLADASaxFrameworkLoader.lib(COLLADASaxFWLRootParser15.obj) : error LNK2001: unresolved external symbol "public: virtual bool __cdecl COLLADASaxFWL::LibraryAnimationClipsLoader15::end__instance_animation(void)" (?end__instance_animation@LibraryAnimationClipsLoader15@COLLADASaxFWL@@UEAA_NXZ) [e:\git\workspace\COLLADA-MAYA-PC-PULL-REQUEST\COLLADAMaya\scripts\COLLADAMaya.vcxproj]
2>..\bin\win\x64\ReleasePlugin2018\COLLADAMaya.mll : fatal error LNK1120: 11 unresolved externals [e:\git\workspace\COLLADA-MAYA-PC-PULL-REQUEST\COLLADAMaya\scripts\COLLADAMaya.vcxproj]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants