Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added animation clip parsing and writer callbacks #596

Merged
merged 9 commits into from
Nov 26, 2018

Conversation

lasalvavida
Copy link
Contributor

Resolves #565 and enables multiple animations support in COLLADA2GLTF: KhronosGroup/COLLADA2GLTF#130.

Re-opened from #592.

Contains updated Visual Studio definitions to hopefully resolve the Maya/Max build issue present in the other PR.

@CLAassistant
Copy link

CLAassistant commented Oct 23, 2018

CLA assistant check
All committers have signed the CLA.

@lasalvavida
Copy link
Contributor Author

@RemiArnaud, if you're okay with it, I'd like to get this pushed through before normalizing formatting since it's holding things up on the COLLADA2GLTF side of things.

@Fl4reBot
Copy link

FAILURE: exercise-opencollada-pull-request build #162

Pull Requests:

@RemiArnaud
Copy link
Contributor

Maya Mac Release 2015:

COLLADASaxFrameworkLoader/src/COLLADASaxFWLRootParser15.cpp:25:10: fatal error: 'COLLADASaxFWLLibraryAnimationClipsLoader15.h' file not found

COLLADASaxFrameworkLoader/src/COLLADASaxFWLRootParser14.cpp:25:10: fatal error: 'COLLADASaxFWLLibraryAnimationClipsLoader14.h' file not found

The MAX issue is a server configuration issue I'll fix asap

@Fl4reBot
Copy link

FAILURE: exercise-opencollada-pull-request build #163

Pull Requests:

@lasalvavida
Copy link
Contributor Author

lasalvavida commented Oct 29, 2018

I have updated the relevant XCode project; hopefully that's the last thing.

After formatting fixes, if you would like, I can take a look at unifying the CMake build a bit. Unless there's a good reason, it just seems a little unintuitive to use CMake across most of the project, but also have checked in Visual Studio and XCode projects.

@Fl4reBot
Copy link

FAILURE: exercise-opencollada-pull-request build #164

Pull Requests:

@RemiArnaud
Copy link
Contributor

RemiArnaud commented Nov 1, 2018

COLLADASaxFrameworkLoader/src/COLLADASaxFWLRootParser15.cpp:25:10: fatal error: 'COLLADASaxFWLLibraryAnimationClipsLoader15.h' file not found
#include "COLLADASaxFWLLibraryAnimationClipsLoader15.h"

COLLADASaxFrameworkLoader/src/COLLADASaxFWLRootParser14.cpp:25:10: fatal error: 'COLLADASaxFWLLibraryAnimationClipsLoader14.h' file not found
#include "COLLADASaxFWLLibraryAnimationClipsLoader14.h"

@lasalvavida
Copy link
Contributor Author

After some difficulty setting up a Mac OS VM, I've updated the XCode project for COLLADAMaya. 🤞

@lasalvavida
Copy link
Contributor Author

@RemiArnaud, could you take a look at this when you get a chance? I'd like to try to get this merged at some point during this week.

@Fl4reBot
Copy link

SUCCESS: exercise-opencollada-pull-request build #166

Pull Requests:

Copy link
Contributor

@RemiArnaud RemiArnaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution

@RemiArnaud RemiArnaud merged commit 6031fa9 into KhronosGroup:master Nov 26, 2018
@lasalvavida lasalvavida deleted the animation-clip-parsing branch November 26, 2018 22:48
@lasalvavida
Copy link
Contributor Author

Awesome, thanks @RemiArnaud!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for importing library animation clips
4 participants