-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added animation clip parsing and writer callbacks #596
Added animation clip parsing and writer callbacks #596
Conversation
@RemiArnaud, if you're okay with it, I'd like to get this pushed through before normalizing formatting since it's holding things up on the COLLADA2GLTF side of things. |
FAILURE: exercise-opencollada-pull-request build #162
Pull Requests:
|
Maya Mac Release 2015: COLLADASaxFrameworkLoader/src/COLLADASaxFWLRootParser15.cpp:25:10: fatal error: 'COLLADASaxFWLLibraryAnimationClipsLoader15.h' file not found COLLADASaxFrameworkLoader/src/COLLADASaxFWLRootParser14.cpp:25:10: fatal error: 'COLLADASaxFWLLibraryAnimationClipsLoader14.h' file not found The MAX issue is a server configuration issue I'll fix asap |
FAILURE: exercise-opencollada-pull-request build #163
Pull Requests:
|
I have updated the relevant XCode project; hopefully that's the last thing. After formatting fixes, if you would like, I can take a look at unifying the CMake build a bit. Unless there's a good reason, it just seems a little unintuitive to use CMake across most of the project, but also have checked in Visual Studio and XCode projects. |
FAILURE: exercise-opencollada-pull-request build #164
Pull Requests:
|
COLLADASaxFrameworkLoader/src/COLLADASaxFWLRootParser15.cpp:25:10: fatal error: 'COLLADASaxFWLLibraryAnimationClipsLoader15.h' file not found COLLADASaxFrameworkLoader/src/COLLADASaxFWLRootParser14.cpp:25:10: fatal error: 'COLLADASaxFWLLibraryAnimationClipsLoader14.h' file not found |
After some difficulty setting up a Mac OS VM, I've updated the XCode project for COLLADAMaya. 🤞 |
@RemiArnaud, could you take a look at this when you get a chance? I'd like to try to get this merged at some point during this week. |
SUCCESS: exercise-opencollada-pull-request build #166
Pull Requests:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution
Awesome, thanks @RemiArnaud! |
Resolves #565 and enables multiple animations support in COLLADA2GLTF: KhronosGroup/COLLADA2GLTF#130.
Re-opened from #592.
Contains updated Visual Studio definitions to hopefully resolve the Maya/Max build issue present in the other PR.