Address feedback on enum validation #2087
Conversation
|
@oddhack are the CIs failing here also failing on main? I can't see any reason for them to fail just from the commits here 🤔 |
I see the same failures on another PR |
Yes, there were some changes in Vulkan-Hpp in response to recent XML schema changes that aren't reflected here yet. Hopefully #2088 will fix that although Actions seems to be running terribly slowly at the moment. |
|
@Tobski if you rebase on main branch it should pass CI now. The Rust bindings are still not working but they're not a blocker. |
| type. | ||
| Use of an enumerant is valid if the following conditions are true: | ||
| An enumerant value is valid for a particular use if the following conditions | ||
| are true: |
There was a problem hiding this comment.
maybe "all the following conditions".
There was a problem hiding this comment.
We're inconsistent about whether we use "all". I agree it wouldn't hurt!
| @@ -233,6 +233,9 @@ include::{generated}/api/protos/vkEnumerateInstanceVersion.adoc[] | |||
| of Vulkan supported by instance-level functionality, encoded as | |||
| described in <<extendingvulkan-coreversions-versionnumbers>>. | |||
|
|
|||
| If flink:vkGetInstanceProcAddr returns a code:NULL pointer when this | |||
There was a problem hiding this comment.
I think styleguide uses only ticks for NULL
| object as its first parameter and either: | ||
| for the current instance. | ||
| * If the enumerant is used in a function that has a dispatchable object | ||
| created or allocated from a device as its first parameter and either: |
There was a problem hiding this comment.
This is incorrect. Either "dispatchable object created or allocated from a physical device" or "dispatchable object that is device or its children".
Fixes #2077
CC @krOoze