Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to fix immediate CI failure issues #2088

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Try to fix immediate CI failure issues #2088

merged 1 commit into from
Mar 20, 2023

Conversation

oddhack
Copy link
Contributor

@oddhack oddhack commented Mar 20, 2023

No description provided.

@oddhack oddhack mentioned this pull request Mar 20, 2023
Open
@oddhack oddhack added this to the Signed-off to Merge milestone Mar 20, 2023
@oddhack
Copy link
Contributor Author

oddhack commented Mar 20, 2023

This gets Vulkan-Hpp building. The Rust bindings are still failing and I'm not sure if that's because they haven't been updated entirely to the new XML schema changes yet, or something else is going on. @MarijnS95 could you take a look at this?

@oddhack oddhack merged commit 75f7e6b into main Mar 20, 2023
@oddhack oddhack deleted the fix-hpp branch March 20, 2023 15:43
@MarijnS95
Copy link
Contributor

@oddhack I made a large push to switch to the new format completely last week, but the PRs have yet to be reviewed by a co-maintainer. I'll notify them to get this into master and unblock the CI's.

@MarijnS95
Copy link
Contributor

@oddhack the PRs in question have now been merged and should solve the CI errors as a byproduct.

@oddhack
Copy link
Contributor Author

oddhack commented Mar 25, 2023

CI is actually working in gitlab and github now, with the rust docker image updated. I don't know if it's working in Vulkan SC, though. https://github.com/KhronosGroup/Vulkan-Docs/actions/runs/4510884368/jobs/7942517161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Signed-off to Merge
Development

Successfully merging this pull request may close these issues.
2 participants
@oddhack @MarijnS95