Fix #5531 bump snapcraft base to core22 #5555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackkav
approved these changes
Dec 20, 2022
1 task
marckong
approved these changes
Dec 23, 2022
onionj
approved these changes
Dec 24, 2022
filfreire
force-pushed
the
fix/issue-5531-ubuntu-snap
branch
from
e086b4b to
41b474c
Compare
filfreire
added a commit
to filfreire/insomnia
that referenced
this pull request
Jan 9, 2023
This was referenced Jan 9, 2023
kreosus
pushed a commit
to kreosus/insomnia
that referenced
this pull request
Jan 10, 2023
* Revert "Fix INS-2242, add afterPack workaround for electron-builder (Kong#5627)" This reverts commit 33aa835. * Revert "Fix Kong#5531 bump snapcraft base to core22 (Kong#5555)" This reverts commit 856c859. * Revert "use same prettify mechanic for both editors (Kong#5616)" This reverts commit 21c7817.
6 tasks
filfreire
added a commit
to jackkav/insomnia
that referenced
this pull request
Jan 11, 2023
filfreire
added a commit
to jackkav/insomnia
that referenced
this pull request
Jan 11, 2023
filfreire
added a commit
to jackkav/insomnia
that referenced
this pull request
Jan 12, 2023
filfreire
added a commit
that referenced
this pull request
Jan 12, 2023
* use electron-build notarize config * update electron-builder.config * Re-add snapcraft fix done in #5555 * update electron-builder Co-authored-by: Filipe Freire <[email protected]>
pavkout
pushed a commit
to pavkout/insomnia
that referenced
this pull request
Jan 18, 2023
Closed
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog(Fixes): Fixed an issue that prevented running Insomnia when installed via Snapcraft /
.snappackageCloses #5531
See this comment
For
.snapbuilds we rely on this template, which uses Ubuntu 18 base image that is too old for latest Electron & node-libcurl - causing folks the issue in #5531The solution was:
core22) - done in feat: Add base option for snapcraft electron-userland/electron-builder#7320electron-builderdependency (app-builder-lib) that allows the override tobaseSeems to work OK in Ubuntu 22
