use electron-build notarize config #5635
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog(Fixes): Fixed an issue (#5637) that prevented Snapcraft builds not working
Closes INS-2248, Related to #5633
Blocks fix for #5531 and #5637 that was originally done in #5555 - we can't use latest electron-builder yet with success
Related issues: electron-userland/electron-builder#7357 and Related PR: electron-userland/electron-builder#7361
Current status
spctl
step when notarizing - saying thedist/mac-universal/Insomnia.app file is not found - /Users/runner/work/***/***/packages/***/dist/mac-universal/Insomnia.app": No such file or directory
- This should be fixed in fix: Remove spctl check from Mac's notarization electron-userland/electron-builder#7361TODO
npmRebuild
to falseentitlementsInherit: './build/static/entitlements.mac.inherit.plist',
next toentitlements
mac
entry: