-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: decouple health/readiness server from manager #7071
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/kic-as-library #7071 +/- ##
=====================================================
Coverage ? 76.6%
=====================================================
Files ? 219
Lines ? 25069
Branches ? 0
=====================================================
Hits ? 19221
Misses ? 4838
Partials ? 1010 ☔ View full report in Codecov by Sentry. |
programmer04
force-pushed
the
expose-readiness
branch
3 times, most recently
from
February 3, 2025 21:13
95639d6
to
4b2721b
Compare
czeslavo
reviewed
Feb 4, 2025
2 tasks
Co-authored-by: Grzegorz Burzyński <[email protected]>
programmer04
force-pushed
the
expose-readiness
branch
from
February 4, 2025 11:57
99fbe87
to
a1c38ca
Compare
czeslavo
reviewed
Feb 4, 2025
czeslavo
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Closes #7044
Special notes for your reviewer:
The only run everywhere called should be this one the internal package should be only used in this import. I'm happy to address it in a separate PR. I think that in such a case ID can be hard coded to e.g.
KIC-classic
.Further telemetry adjustments should be addressed in #7048