Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: decouple health/readiness server from manager #7071

Merged
merged 4 commits into from
Feb 4, 2025

Conversation

programmer04
Copy link
Member

@programmer04 programmer04 commented Feb 3, 2025

What this PR does / why we need it:

Closes #7044

Special notes for your reviewer:

The only run everywhere called should be this one the internal package should be only used in this import. I'm happy to address it in a separate PR. I think that in such a case ID can be hard coded to e.g. KIC-classic.

Further telemetry adjustments should be addressed in #7048

@programmer04 programmer04 self-assigned this Feb 3, 2025
@programmer04 programmer04 requested a review from a team as a code owner February 3, 2025 17:35
@programmer04 programmer04 added refactor area/feature New feature or request labels Feb 3, 2025
@programmer04 programmer04 enabled auto-merge (squash) February 3, 2025 17:36
@programmer04 programmer04 requested a review from czeslavo February 3, 2025 17:36
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 49.42529% with 44 lines in your changes missing coverage. Please review.

Please upload report for BASE (feat/kic-as-library@e55bf68). Learn more about missing BASE report.

Files with missing lines Patch % Lines
internal/manager/run.go 43.9% 22 Missing and 1 partial ⚠️
internal/cmd/rootcmd/run.go 0.0% 10 Missing ⚠️
internal/util/test/controller_manager.go 14.2% 4 Missing and 2 partials ⚠️
pkg/manager/manager.go 68.7% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             feat/kic-as-library   #7071   +/-   ##
=====================================================
  Coverage                       ?   76.6%           
=====================================================
  Files                          ?     219           
  Lines                          ?   25069           
  Branches                       ?       0           
=====================================================
  Hits                           ?   19221           
  Misses                         ?    4838           
  Partials                       ?    1010           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@programmer04 programmer04 force-pushed the expose-readiness branch 3 times, most recently from 95639d6 to 4b2721b Compare February 3, 2025 21:13
internal/manager/run.go Show resolved Hide resolved
internal/manager/run.go Outdated Show resolved Hide resolved
internal/cmd/rootcmd/run.go Show resolved Hide resolved
internal/manager/health/health_check.go Outdated Show resolved Hide resolved
internal/manager/health/health_check.go Outdated Show resolved Hide resolved
pkg/manager/manager.go Show resolved Hide resolved
pkg/manager/manager.go Outdated Show resolved Hide resolved
@programmer04 programmer04 requested a review from czeslavo February 4, 2025 11:10
@programmer04 programmer04 linked an issue Feb 4, 2025 that may be closed by this pull request
2 tasks
pkg/manager/manager.go Outdated Show resolved Hide resolved
@programmer04 programmer04 merged commit 5031029 into feat/kic-as-library Feb 4, 2025
41 checks passed
@programmer04 programmer04 deleted the expose-readiness branch February 4, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An instance health/readiness can be examined via Go API instead of HTTP
2 participants