Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: decouple health/readiness server from manager #7071

Merged
merged 4 commits into from
Feb 4, 2025

move constructors

32f7eee
Select commit
Loading
Failed to load commit list.
Merged

chore: decouple health/readiness server from manager #7071

move constructors
32f7eee
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 4, 2025 in 1s

No report found to compare against

View this Pull Request on Codecov

No report found to compare against

Details

Codecov Report

Attention: Patch coverage is 55.84416% with 34 lines in your changes missing coverage. Please review.

Please upload report for BASE (feat/kic-as-library@e55bf68). Learn more about missing BASE report.

Files with missing lines Patch % Lines
internal/manager/run.go 43.9% 22 Missing and 1 partial ⚠️
internal/util/test/controller_manager.go 14.2% 4 Missing and 2 partials ⚠️
pkg/manager/manager.go 68.7% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             feat/kic-as-library   #7071   +/-   ##
=====================================================
  Coverage                       ?   52.9%           
=====================================================
  Files                          ?     214           
  Lines                          ?   24963           
  Branches                       ?       0           
=====================================================
  Hits                           ?   13215           
  Misses                         ?   10602           
  Partials                       ?    1146           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.