Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed rel="shortcut icon" to rel="icon" #1305

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Conversation

heull001
Copy link
Contributor

@heull001 heull001 commented Jun 6, 2023

"icon" is standard and used by all modern browsers. Only IE needed "shortcut icon". Since is it not longer supported and would have needed an .ico-file, "icon" is the right value for rel.

"icon" is standard and used by all modern browsers. Only IE needed
"shortcut icon". Since is it not longer supported and would have needed an
.ico-file, "icon" is the right value for rel.
Copy link
Collaborator

@pbiering pbiering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

MatthewHana added a commit to MatthewHana/Radicale-newwebui that referenced this pull request Aug 31, 2023
Incorporated pull requests Kozea#1305 and Kozea#1306.

Restored declaration of 'hidden' class to index file.

Restored h2 in sections for navigation purposes.

Cleaned up index.html.
@MatthewHana MatthewHana mentioned this pull request Sep 3, 2023
@pbiering pbiering self-assigned this Mar 1, 2024
@pbiering pbiering merged commit 998e2f9 into Kozea:master Mar 1, 2024
@heull001 heull001 deleted the icon branch March 4, 2024 22:04
MatthewHana added a commit to MatthewHana/Radicale-newwebui that referenced this pull request Mar 5, 2024
Incorporated pull requests Kozea#1305 and Kozea#1306.

Restored declaration of 'hidden' class to index file.

Restored h2 in sections for navigation purposes.

Cleaned up index.html.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants