-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Web UI #1329
New Web UI #1329
Conversation
* New Web UI Updated web UI to a more modern interface while keeping the HTML structure as similar to the original as possible. New features include: -Mobile view compatibility -New light color scheme using primary colors based off Radicale's official colors -Dialog theme for most sections -Floating Action Buttons (FAB's) for creating and uploading a new collection -Commands to edit/delete a collection have become buttons that only show on hover. -Improved loading screen -New loading circle with consistent color scheme -More explanation for dialog text -Added warning to delete screen --------- Co-authored-by: Matthew Hana <[email protected]>
I merged it into my fork, but it seems that the icons will not load. 🤔 |
Do they 404 or is it something else? The icons are SVG so they should render on all modern browsers. Which browser are you using? |
404, and Opera. |
@MatthewHana : please rebase this to v3.2-devel branch |
I will rebase this in a few days and also add support for PR #1229 |
@MatthewHana : can you also work on optional CAPTCHA support like already discussed here: #1257 - best in an abstract way so at least the 4 known ones can be used + potential upcoming ones easily added. If you need help, I can potentially support here as having implemented or extended CAPTCHA support in native Phyton / Python+Django / PHP / Perl already. |
Sure, I'll have a look into it. |
Updated web UI to a more modern interface while keeping the HTML structure as similar to the original as possible. New features include: -Mobile view compatibility -New light color scheme using primary colors based off Radicale's official colors -Dialog theme for most sections -Floating Action Buttons (FAB's) for creating and uploading a new collection -Commands to edit/delete a collection have become buttons that only show on hover. -Improved loading screen -New loading circle with consistent color scheme -More explanation for dialog text -Added warning to delete screen
Deleted duplicate file.
Delete duplicate file.
Incorporated pull requests Kozea#1305 and Kozea#1306. Restored declaration of 'hidden' class to index file. Restored h2 in sections for navigation purposes. Cleaned up index.html.
|
While adding a captcha, please don't use Google's. |
There is a simple captcha solution available from pypi --> https://captcha.lepture.com/ |
I would suggest keeping it flexible and implement
I have implementations running supporting all 4 by simple toggles, would recommend having this also for "Radicale". Only for hints: python/Django: https://github.com/pbiering/mailman3-rpm/blob/main/django_multi_captcha_support.py python(Mailman2/reCaptcha extension with FriendlyCaptcha+hCaptcha): https://launchpadlibrarian.net/596731924/mailman-2.1-hCaptcha-FriendyCaptcha-20220415.diff |
They dropped support for Python 3.7 in latest release, this would lead to question which Python versions should be supported at all. |
This is what most of regularly updated packages do / Python EOL was in 2023-06-27 .. about vobject see comment from @da4089 --> py-vobject/vobject#1 (comment) |
Added support to view, edit, and add Webcals in web UI to support functionality added in PR Kozea#1229.
Hi all, please see discussion #1402 regarding CAPTCHA. It unfortunately can not be handled in this PR. |
Hi @samip5, I couldn't get it to 404. Any possibility of sharing your Devtools network log or anything that could help me to replicate? Is it a possibly a content security policy issue? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only code review, functional tests will be done later
Merged, please let test further |
looks all fine now, minor candidates for improvement found:
|
What I would like to do next is a holistic refactoring of the web client JavaScript to make it easier to add functionality into the future. I also want to split it into multiple JS to make it easier to make and track changes to the code. Currently UI, DAV, and Helper functions are all in the same file- I would like to split them up and eventually implement JS testing. |
That is a very good idea, do you suggest starting 3.2.0 before or postpone until this is done? In principle, there is no hurry for 3.2.0 at the moment anyhow. |
Updated web UI to a more modern interface while keeping the HTML structure as similar to the original as possible. Fewest possible modifications were made to fn.js and only in relation to UI enhancements.
This PR incorporates pull requests #1305 and #1306.
Updates include:
-Mobile view compatibility
-New light color scheme using primary colors based off Radicale's official colors
-Dialog theme for most sections
-Floating Action Buttons (FAB's) for creating and uploading a new collection
-Commands to edit/delete a collection have become buttons that only show on hover.
-Improved loading screen
-New loading circle with consistent color scheme
-More explanation for dialog text
-Added warning to delete screen
-Consistent capitalisation
-Moved styling from HTML to CSS
-Support for Webcal subscriptions (support added in PR #1229) (NEW)