Remove overhead of default InstrumentedFunction #163
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently found out about the very nice "instrumented function" feature introduced by @ericphanson in #152.
After trying it out, I noticed that by default it has some additional overhead and allocations associated to the creation of the string representation of the instrumented function using
repr
. The overhead disappears when one directly passes a string instead of using the default.Here is a small example:
This PR completely removes the overhead in the first case, by using a generated function when possible to generate the function name.