Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove overhead of default InstrumentedFunction #163

Merged
merged 1 commit into from
Apr 24, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/utilities.jl
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,15 @@ struct InstrumentedFunction{F} <: Function
name::String
end

InstrumentedFunction(f, t) = InstrumentedFunction(f, t, string(repr(f)))
function funcname(f::F) where {F}
if @generated
string(repr(F.instance))
else
string(repr(f))
end
end

InstrumentedFunction(f, t) = InstrumentedFunction(f, t, funcname(f))

function (inst::InstrumentedFunction)(args...; kwargs...)
@timeit inst.t inst.name inst.func(args...; kwargs...)
Expand All @@ -155,4 +163,4 @@ Instruments `f` by the [`TimerOutput`](@ref) `t` returning an `InstrumentedFunct
This function can be used just like `f`, but whenever it is called it stores timing
results in `t`.
"""
(t::TimerOutput)(f, name=string(repr(f))) = InstrumentedFunction(f, t, name)
(t::TimerOutput)(f, name=funcname(f)) = InstrumentedFunction(f, t, name)