Move peak controller out of core #5247
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reflexe
added
core
needs code review
This commit also introduces the usage of ControllerFactory in Controller::create. That's done in order to support dynamic loading of PeakControllers.
Reflexe
force-pushed
the
fix-peak-controller
branch
from
1b0fd9b to
20608b0
Compare
🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request!
Linux
Windows
🤖{"commit_sha": "19aee85922f1841b04d5695ba8174df6ceb68c2c", "platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://1119-143851518-gh.circle-artifacts.com/0/lmms-1.2.0-rc6.726-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/Reflexe/lmms/1119?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://1120-143851518-gh.circle-artifacts.com/0/lmms-1.2.0-rc6.726-win32.exe"}}, "build_link": "https://circleci.com/gh/Reflexe/lmms/1120?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://1121-143851518-gh.circle-artifacts.com/0/lmms-1.2.0-rc6.726-win64.exe"}}, "build_link": "https://circleci.com/gh/Reflexe/lmms/1121?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/2ysik87ph10a3pqs/artifacts/build/lmms-1.2.0-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/28191953"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/89xgjy5fn2nv80jk/artifacts/build/lmms-1.2.0-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/28191953"}]}} |
|
I suggest something different: can we move the peak controller effect to LMMS itself? |
56 tasks
|
Closing for now, we should decide which one to move. This can be reopened once we decide this is the way to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5242