Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rewards v2.1 state models #197

Merged
merged 1 commit into from
Jan 30, 2025
Merged

feat: rewards v2.1 state models #197

merged 1 commit into from
Jan 30, 2025

Conversation

0xrajath
Copy link
Contributor

@0xrajath 0xrajath commented Jan 24, 2025 •
edited
Loading

Rewards v2.1 state models

@0xrajath 0xrajath self-assigned this Jan 24, 2025
@0xrajath 0xrajath changed the title feat: rewards 2.1 state models feat: rewards v2.1 state models Jan 24, 2025
@seanmcgary seanmcgary modified the milestones: v2.1.0, v3.0.0 - Slashing Jan 27, 2025
@0xrajath 0xrajath force-pushed the rajath/rewards-v2.1-state-models branch from 3a01f0a to 02fd47c Compare January 28, 2025 23:34
@0xrajath 0xrajath marked this pull request as ready for review January 28, 2025 23:35
@0xrajath 0xrajath requested a review from a team as a code owner January 28, 2025 23:35
@0xrajath 0xrajath requested a review from seanmcgary January 28, 2025 23:35
seanmcgary
seanmcgary requested changes Jan 30, 2025
View reviewed changes
Copy link
Member

@seanmcgary seanmcgary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just a few nit picky things

...operatorDirectedOperatorSetRewardSubmissions/operatorDirectedOperatorSetRewardSubmissions.go Outdated Show resolved Hide resolved
...operatorDirectedOperatorSetRewardSubmissions/operatorDirectedOperatorSetRewardSubmissions.go Outdated Show resolved Hide resolved
...operatorDirectedOperatorSetRewardSubmissions/operatorDirectedOperatorSetRewardSubmissions.go Outdated Show resolved Hide resolved
...torDirectedOperatorSetRewardSubmissions/operatorDirectedOperatorSetRewardSubmissions_test.go Outdated Show resolved Hide resolved
pkg/eigenState/operatorSetOperatorRegistrations/operatorSetOperatorRegistrations.go Outdated Show resolved Hide resolved
pkg/eigenState/operatorSetSplits/operatorSetSplits.go Outdated Show resolved Hide resolved
pkg/eigenState/operatorSetSplits/operatorSetSplits_test.go Outdated Show resolved Hide resolved
pkg/eigenState/operatorSetStrategyRegistrations/operatorSetStrategyRegistrations.go Outdated Show resolved Hide resolved
@seanmcgary seanmcgary force-pushed the release/rewards-v2.1 branch from 3fef97c to 9418865 Compare January 30, 2025 16:14
@seanmcgary seanmcgary force-pushed the rajath/rewards-v2.1-state-models branch from 8688445 to 53c387b Compare January 30, 2025 16:17
@seanmcgary seanmcgary merged commit b0c93a9 into release/rewards-v2.1 Jan 30, 2025
8 checks passed
@seanmcgary seanmcgary deleted the rajath/rewards-v2.1-state-models branch January 30, 2025 20:41
@0xrajath 0xrajath mentioned this pull request Jan 31, 2025
Merged
0xrajath added a commit that referenced this pull request Feb 4, 2025
@0xrajath
feat: rewards 2.1 calculation (#215)
5b9d766 
# Motivation
We need to support Rewards v2.1 calculation. 

This PR builds on top of #197
which supported the Eigen state models for
`OperatorDirectedOperatorSetRewardSubmissions`, `OperatorSetSplits`,
`OperatorSetOperatorRegistrations`, `OperatorSetStrategyRegistrations`.

# Modifications
* Snapshot generation for:
`OperatorDirectedOperatorSetRewardSubmissions`, `OperatorSetSplits`,
`OperatorSetOperatorRegistrations`, `OperatorSetStrategyRegistrations`.
* Refactoring Staging and Final numbering from 11 and 12 to 15 and 16.
* Mississippi hard fork for Rewards v2.1.
* New Operator Directed Operator Set rewards calculation to be triggered
after Mississippi hard fork.
* Updated Rewards For All Earners (Programmatic Incentives) calculation
to include operators registered to operator sets after Mississippi hard
fork.
* Staker-operator calculation for Rewards v2.1. 

# Results
Rewards v2.1 calculation.

# Tests
Existing Rewards tests passing.

<img width="660" alt="Screenshot 2025-01-31 at 1 33 38 PM"
src="https://github.com/user-attachments/assets/876c2d7c-be22-48b6-a046-55ead8a12530"
/>
seanmcgary added a commit that referenced this pull request Feb 5, 2025
@seanmcgary
feat: rewards v2.1 state models (#197)
89c61ec 
Rewards v2.1 state models
seanmcgary pushed a commit that referenced this pull request Feb 5, 2025
@0xrajath @seanmcgary
feat: rewards 2.1 calculation (#215)
b1e4568 
# Motivation
We need to support Rewards v2.1 calculation. 

This PR builds on top of #197
which supported the Eigen state models for
`OperatorDirectedOperatorSetRewardSubmissions`, `OperatorSetSplits`,
`OperatorSetOperatorRegistrations`, `OperatorSetStrategyRegistrations`.

# Modifications
* Snapshot generation for:
`OperatorDirectedOperatorSetRewardSubmissions`, `OperatorSetSplits`,
`OperatorSetOperatorRegistrations`, `OperatorSetStrategyRegistrations`.
* Refactoring Staging and Final numbering from 11 and 12 to 15 and 16.
* Mississippi hard fork for Rewards v2.1.
* New Operator Directed Operator Set rewards calculation to be triggered
after Mississippi hard fork.
* Updated Rewards For All Earners (Programmatic Incentives) calculation
to include operators registered to operator sets after Mississippi hard
fork.
* Staker-operator calculation for Rewards v2.1. 

# Results
Rewards v2.1 calculation.

# Tests
Existing Rewards tests passing.

<img width="660" alt="Screenshot 2025-01-31 at 1 33 38 PM"
src="https://github.com/user-attachments/assets/876c2d7c-be22-48b6-a046-55ead8a12530"
/>
seanmcgary added a commit that referenced this pull request Feb 10, 2025
@seanmcgary
feat: rewards v2.1 state models (#197)
3eb0e25 
Rewards v2.1 state models
seanmcgary pushed a commit that referenced this pull request Feb 10, 2025
@0xrajath @seanmcgary
feat: rewards 2.1 calculation (#215)
0ae9586 
# Motivation
We need to support Rewards v2.1 calculation. 

This PR builds on top of #197
which supported the Eigen state models for
`OperatorDirectedOperatorSetRewardSubmissions`, `OperatorSetSplits`,
`OperatorSetOperatorRegistrations`, `OperatorSetStrategyRegistrations`.

# Modifications
* Snapshot generation for:
`OperatorDirectedOperatorSetRewardSubmissions`, `OperatorSetSplits`,
`OperatorSetOperatorRegistrations`, `OperatorSetStrategyRegistrations`.
* Refactoring Staging and Final numbering from 11 and 12 to 15 and 16.
* Mississippi hard fork for Rewards v2.1.
* New Operator Directed Operator Set rewards calculation to be triggered
after Mississippi hard fork.
* Updated Rewards For All Earners (Programmatic Incentives) calculation
to include operators registered to operator sets after Mississippi hard
fork.
* Staker-operator calculation for Rewards v2.1. 

# Results
Rewards v2.1 calculation.

# Tests
Existing Rewards tests passing.

<img width="660" alt="Screenshot 2025-01-31 at 1 33 38 PM"
src="https://github.com/user-attachments/assets/876c2d7c-be22-48b6-a046-55ead8a12530"
/>
seanmcgary added a commit that referenced this pull request Feb 11, 2025
@seanmcgary
feat: rewards v2.1 state models (#197)
7a00052 
Rewards v2.1 state models
seanmcgary pushed a commit that referenced this pull request Feb 11, 2025
@0xrajath @seanmcgary
feat: rewards 2.1 calculation (#215)
0eb28ed 
# Motivation
We need to support Rewards v2.1 calculation. 

This PR builds on top of #197
which supported the Eigen state models for
`OperatorDirectedOperatorSetRewardSubmissions`, `OperatorSetSplits`,
`OperatorSetOperatorRegistrations`, `OperatorSetStrategyRegistrations`.

# Modifications
* Snapshot generation for:
`OperatorDirectedOperatorSetRewardSubmissions`, `OperatorSetSplits`,
`OperatorSetOperatorRegistrations`, `OperatorSetStrategyRegistrations`.
* Refactoring Staging and Final numbering from 11 and 12 to 15 and 16.
* Mississippi hard fork for Rewards v2.1.
* New Operator Directed Operator Set rewards calculation to be triggered
after Mississippi hard fork.
* Updated Rewards For All Earners (Programmatic Incentives) calculation
to include operators registered to operator sets after Mississippi hard
fork.
* Staker-operator calculation for Rewards v2.1. 

# Results
Rewards v2.1 calculation.

# Tests
Existing Rewards tests passing.

<img width="660" alt="Screenshot 2025-01-31 at 1 33 38 PM"
src="https://github.com/user-attachments/assets/876c2d7c-be22-48b6-a046-55ead8a12530"
/>
seanmcgary added a commit that referenced this pull request Feb 11, 2025
@seanmcgary
feat: rewards v2.1 state models (#197)
9a0a28f 
Rewards v2.1 state models
seanmcgary pushed a commit that referenced this pull request Feb 11, 2025
@0xrajath @seanmcgary
feat: rewards 2.1 calculation (#215)
a4e13ab 
# Motivation
We need to support Rewards v2.1 calculation. 

This PR builds on top of #197
which supported the Eigen state models for
`OperatorDirectedOperatorSetRewardSubmissions`, `OperatorSetSplits`,
`OperatorSetOperatorRegistrations`, `OperatorSetStrategyRegistrations`.

# Modifications
* Snapshot generation for:
`OperatorDirectedOperatorSetRewardSubmissions`, `OperatorSetSplits`,
`OperatorSetOperatorRegistrations`, `OperatorSetStrategyRegistrations`.
* Refactoring Staging and Final numbering from 11 and 12 to 15 and 16.
* Mississippi hard fork for Rewards v2.1.
* New Operator Directed Operator Set rewards calculation to be triggered
after Mississippi hard fork.
* Updated Rewards For All Earners (Programmatic Incentives) calculation
to include operators registered to operator sets after Mississippi hard
fork.
* Staker-operator calculation for Rewards v2.1. 

# Results
Rewards v2.1 calculation.

# Tests
Existing Rewards tests passing.

<img width="660" alt="Screenshot 2025-01-31 at 1 33 38 PM"
src="https://github.com/user-attachments/assets/876c2d7c-be22-48b6-a046-55ead8a12530"
/>
seanmcgary added a commit that referenced this pull request Feb 12, 2025
@seanmcgary
feat: rewards v2.1 state models (#197)
0b941f0 
Rewards v2.1 state models
seanmcgary pushed a commit that referenced this pull request Feb 12, 2025
@0xrajath @seanmcgary
feat: rewards 2.1 calculation (#215)
91b7bf9 
# Motivation
We need to support Rewards v2.1 calculation. 

This PR builds on top of #197
which supported the Eigen state models for
`OperatorDirectedOperatorSetRewardSubmissions`, `OperatorSetSplits`,
`OperatorSetOperatorRegistrations`, `OperatorSetStrategyRegistrations`.

# Modifications
* Snapshot generation for:
`OperatorDirectedOperatorSetRewardSubmissions`, `OperatorSetSplits`,
`OperatorSetOperatorRegistrations`, `OperatorSetStrategyRegistrations`.
* Refactoring Staging and Final numbering from 11 and 12 to 15 and 16.
* Mississippi hard fork for Rewards v2.1.
* New Operator Directed Operator Set rewards calculation to be triggered
after Mississippi hard fork.
* Updated Rewards For All Earners (Programmatic Incentives) calculation
to include operators registered to operator sets after Mississippi hard
fork.
* Staker-operator calculation for Rewards v2.1. 

# Results
Rewards v2.1 calculation.

# Tests
Existing Rewards tests passing.

<img width="660" alt="Screenshot 2025-01-31 at 1 33 38 PM"
src="https://github.com/user-attachments/assets/876c2d7c-be22-48b6-a046-55ead8a12530"
/>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmcgary seanmcgary seanmcgary approved these changes

Assignees

@0xrajath 0xrajath

Labels
None yet
Projects
None yet
Milestone
v3.0.0 - Slashing
Development

Successfully merging this pull request may close these issues.
2 participants
@0xrajath @seanmcgary