feat: rewards 2.1 calculation #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xrajath
force-pushed
the
rajath/rewards-v2.1-snapshots
branch
from
f1c652c to
79bad9a
Compare
seanmcgary
requested changes
Feb 3, 2025
There was a problem hiding this comment.
Looks pretty good overall, just a handful of comments.
@0xrajath can you also add the corresponding inserts for the staker-operator table for rewards v2.1 as well? You should be able to follow what I did for the regular rewards v2 queries.
pkg/postgres/migrations/202501301458_operatorSetSplitSnapshots/up.go
Outdated
Show resolved
Hide resolved
pkg/postgres/migrations/202501301502_operatorSetOperatorRegistrationSnapshots/up.go
Outdated
Show resolved
Hide resolved
pkg/postgres/migrations/202501301505_operatorSetStrategyRegistrationSnapshots/up.go
Outdated
Show resolved
Hide resolved
pkg/postgres/migrations/202501301945_operatorDirectedOperatorSetRewards/up.go
Show resolved
Hide resolved
ypatil12
requested changes
Feb 3, 2025
pkg/postgres/migrations/202501301945_operatorDirectedOperatorSetRewards/up.go
Outdated
Show resolved
Hide resolved
|
@seanmcgary I've added the staker-operator calculation in 089c94a |
seanmcgary
approved these changes
Feb 4, 2025
ypatil12
reviewed
Feb 4, 2025
ypatil12
approved these changes
Feb 4, 2025
seanmcgary
pushed a commit
that referenced
this pull request
Feb 5, 2025
# Motivation We need to support Rewards v2.1 calculation. This PR builds on top of #197 which supported the Eigen state models for `OperatorDirectedOperatorSetRewardSubmissions`, `OperatorSetSplits`, `OperatorSetOperatorRegistrations`, `OperatorSetStrategyRegistrations`. # Modifications * Snapshot generation for: `OperatorDirectedOperatorSetRewardSubmissions`, `OperatorSetSplits`, `OperatorSetOperatorRegistrations`, `OperatorSetStrategyRegistrations`. * Refactoring Staging and Final numbering from 11 and 12 to 15 and 16. * Mississippi hard fork for Rewards v2.1. * New Operator Directed Operator Set rewards calculation to be triggered after Mississippi hard fork. * Updated Rewards For All Earners (Programmatic Incentives) calculation to include operators registered to operator sets after Mississippi hard fork. * Staker-operator calculation for Rewards v2.1. # Results Rewards v2.1 calculation. # Tests Existing Rewards tests passing. <img width="660" alt="Screenshot 2025-01-31 at 1 33 38 PM" src="https://github.com/user-attachments/assets/876c2d7c-be22-48b6-a046-55ead8a12530" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We need to support Rewards v2.1 calculation.
This PR builds on top of #197 which supported the Eigen state models for
OperatorDirectedOperatorSetRewardSubmissions,OperatorSetSplits,OperatorSetOperatorRegistrations,OperatorSetStrategyRegistrations.Modifications
OperatorDirectedOperatorSetRewardSubmissions,OperatorSetSplits,OperatorSetOperatorRegistrations,OperatorSetStrategyRegistrations.Results
Rewards v2.1 calculation.
Tests
Existing Rewards tests passing.