Fix identification of libjvm.so in Java 9+ on Linux #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The location of libjvm.so on Linux/Solaris changed in Java 9 from lib/[arch] to simply lib (see JEP 220). This small fix adds an empty string as an additional arches element for Linux when locating the JDK shared library.
|
Thanks, David, sorry for getting to this so late - just getting back from vacation. |
|
Great, thanks for incorporating it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The location of
libjvm.soon Linux/Solaris changed in Java 9 fromlib/archto simplylib(see JEP 220), which prevents installation of Javabridge in these configurations as mentioned in #137 . This small fix adds an empty string as an additionalarcheselement for Linux when locating the JDK shared library.Tested on these platforms: