Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix identification of libjvm.so in Java 9+ on Linux #141

Merged
merged 1 commit into from
Aug 22, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix identification of libjvm.so in Java 9+ on Linux
The location of libjvm.so on Linux/Solaris changed in Java 9 from lib/[arch] to simply lib (see JEP 220). This small fix adds an empty string as an additional arches element for Linux when locating the JDK shared library.
yoda-vid committed Aug 3, 2018
commit 3c7b08e70e9cb502f5561d250e91208e747e498b
2 changes: 1 addition & 1 deletion javabridge/locate.py
Original file line number Diff line number Diff line change
@@ -228,7 +228,7 @@ def find_jre_bin_jdk_so():
for jre_home in (java_home, os.path.join(java_home, "jre")):
jre_bin = os.path.join(jre_home, 'bin')
jre_libexec = os.path.join(jre_home, 'bin' if is_win else 'lib')
arches = ('amd64', 'i386') if is_linux else ('',)
arches = ('amd64', 'i386', '') if is_linux else ('',)
lib_prefix = '' if is_win else 'lib'
lib_suffix = '.dll' if is_win else ('.dylib' if is_mac else '.so')
for arch in arches: