Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bubble menu doesn't appear when using keyboard select all shortcut #97

Closed
justanotherco opened this issue Jun 2, 2020 · 2 comments
Closed

Comments

@justanotherco
Copy link

Hi again,

If you press cmd + A to select all the text, the bubble menu doesn't appear here:

https://leecason.github.io/element-tiptap/bubble_menu

But it does here:

https://tiptap.scrumpy.io/menu-bubble

Is this a bug in Element tiptap?

Thanks.

@Leecason
Copy link
Owner

Leecason commented Jun 6, 2020

I've overwritten the code of appearing bubble menu, that is different from tiptap's, I will try to improve this, thank you.

Leecason pushed a commit that referenced this issue Jul 5, 2020
# [1.25.0](https://github.com/Leecason/element-tiptap/compare/@[email protected]) (2020-07-05)

### Bug Fixes

* 🎨 type definings ([9cc1274](9cc1274))
* 🐛 show bubble menu when all select (#97) ([b495bec](b495bec))

### Features

* ✨ add `defaultWidth`, `defaultDisplay` options for `Image` extension ([64bc1b6](64bc1b6))
* ✨ add `editorClass`, `editorContentClass`, `editorMenubarClass`, `editorBubbleMenuClass`, `editorFooterClass` props (#133) ([d43d61e](d43d61e))
* ✨ add `lang` prop to support config editor i18n language locally (#62) ([e28b6bd](e28b6bd))
* ✨ add `openInNewTab` option to `Link` extension, default to `true` ([f66ff5e](f66ff5e))
* ✨ add `tooltip` prop to enable/disable tooltip (#121) ([08db78e](08db78e))
* ✨ Add new language `zh-tw` ([be52f57](be52f57))
* ✨ default export `ElementTiptapPlugin` ([bf1726f](bf1726f))
* ✨ enable back to default menu in link bubble menu (#117) ([1805987](1805987))
@Leecason
Copy link
Owner

Leecason commented Jul 5, 2020

🎉 This issue has been resolved in version 1.25.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants