Addition the menubar position in props #133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repository owner
deleted a comment from
isv9
Jun 30, 2020
Repository owner
deleted a comment from
isv9
Jun 30, 2020
Repository owner
deleted a comment from
isv9
Jun 30, 2020
|
Thank you for your pr❤️. |
|
You can add menubarPosition with ['top', 'bottom'] only and don't add 'left' and 'right' |
|
Does |
Leecason
added a commit
that referenced
this pull request
Jul 5, 2020
…, `editorBubbleMenuClass`, `editorFooterClass` props (#133) https://github.com/Leecason/element-tiptap/pull/133`
Leecason
pushed a commit
that referenced
this pull request
Jul 5, 2020
# [1.25.0](https://github.com/Leecason/element-tiptap/compare/@[email protected]) (2020-07-05) ### Bug Fixes * 🎨 type definings ([9cc1274](9cc1274)) * 🐛 show bubble menu when all select (#97) ([b495bec](b495bec)) ### Features * ✨ add `defaultWidth`, `defaultDisplay` options for `Image` extension ([64bc1b6](64bc1b6)) * ✨ add `editorClass`, `editorContentClass`, `editorMenubarClass`, `editorBubbleMenuClass`, `editorFooterClass` props (#133) ([d43d61e](d43d61e)) * ✨ add `lang` prop to support config editor i18n language locally (#62) ([e28b6bd](e28b6bd)) * ✨ add `openInNewTab` option to `Link` extension, default to `true` ([f66ff5e](f66ff5e)) * ✨ add `tooltip` prop to enable/disable tooltip (#121) ([08db78e](08db78e)) * ✨ Add new language `zh-tw` ([be52f57](be52f57)) * ✨ default export `ElementTiptapPlugin` ([bf1726f](bf1726f)) * ✨ enable back to default menu in link bubble menu (#117) ([1805987](1805987))
|
I add |
|
yes, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I needed to set menubar in the bottom position and I did it by css order. Can you look it and if you think that is ok you will add it to your project. Thanks