This repository has been archived by the owner on Dec 2, 2024. It is now read-only.
Fix snapshots #68
Merged
Fix snapshots #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ralphtheninja I just realized: maybe we should work in a v3 branch first? |
I have no strong opinions about it since master will become |
|
Nah it's fine :) |
ralphtheninja
suggested changes
May 23, 2018
iterator.js
Outdated
| Iterator.prototype._next = function (callback) { | ||
| // TODO: can remove this after upgrading abstract-leveldown | ||
| if (!callback) return new Error('next() requires a callback argument') |
There was a problem hiding this comment.
Returning an error looks a bit odd, shouldn't it throw?
There was a problem hiding this comment.
Woa, dunno why I missed that 😄
ralphtheninja
approved these changes
May 23, 2018
This was referenced May 23, 2018
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #63, closes #61, closes #43, also tackles #42, supersedes #51.
At a later time, we can add an option that favors backpressure over snapshot guarantees, by reading lazily from multiple successive cursors.