This repository has been archived by the owner on Dec 2, 2024. It is now read-only.
Simplify value encoding aka serialization #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vweevers
commented
May 23, 2018
| Level.prototype._serializeValue = function (value, options) { | ||
| // TODO: do we still need to support ArrayBuffer? | ||
| if (value instanceof ArrayBuffer) return Buffer.from(value) | ||
| if (value == null) return '' |
There was a problem hiding this comment.
This is the same behavior as the default abstract _serializeValue.
vweevers
commented
May 23, 2018
| if (options.raw) return value | ||
|
|
||
| // TODO: remove | ||
| if (typeof value !== 'object') return value.toString() |
There was a problem hiding this comment.
Similar to memdown, in the next stage, level-js can just return the value as-is, without conversion.
|
Again I assigned, when I meant to request a review. 😦 |
|
The Chrome test has stalled. Looking into it. |
ralphtheninja
approved these changes
May 23, 2018
|
I'll rebase this after fixing #77. |
vweevers
changed the title
vweevers
force-pushed
the
simplify-value-encoding
branch
from
c83fa41 to
057c43a
Compare
vweevers
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Baby steps. It's kind of a miracle that this passes tests 😄
Next step is to take the leap and upgrade
abstract-leveldown, which will be a bigger PR.