-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Weights & Biases (W&B) Fabric Logger #19077
Conversation
Removed references to PT specific functionality like checkpoint Removed Trainer references from tests
…pture both workflows Add stricter type hints on fabric to ensure that only pytorch specific imports occur in pytorch specific function call Add tests to pytorch tests to test both vanilla and fabric logger add fabric specific tests
Fix types Add properties from Logger interface
Format to match other fabric loggers better
I'm having difficulty adding in the resultant docs page for the API on the logger if anyone is able to assist! |
@awaelchli I noticed some failing tests. Would love discuss how I can get these resolved! |
update minimum package requirement for wandb
This reverts commit 7de4ba5.
prevent strict logging based on success only
Is there anything I can pointedly fix here? Would love to discuss! |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #19077 +/- ##
==========================================
- Coverage 84% 45% -38%
==========================================
Files 445 441 -4
Lines 37289 37395 +106
==========================================
- Hits 31185 16981 -14204
- Misses 6104 20414 +14310 |
Hey! @Borda sorry for the bump. Hope your holidays are/were lovely. Would love to discuss what can be fixed to merge this! |
@awaelchli @Borda Would love to see what I can do to fix the failing docs test! Would also love to discuss if there are any other errors that need fixing if they exist |
add missing wandb module in docs building
This specific error is being raised by Sphinx however in my Fabric docstrings I do not refer to |
|
GitGuardian id | Secret | Commit | Filename | |
---|---|---|---|---|
- | Generic High Entropy Secret | 78fa3af | tests/tests_app/utilities/test_login.py | View secret |
- | Base64 Basic Authentication | 78fa3af | tests/tests_app/utilities/test_login.py | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
Closing in favor of #19451 |
What does this PR do?
lightning.pytorch.loggers.WandbLogger
intolightning.fabric.loggers.WandbLogger
.Fixes #17885
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--19077.org.readthedocs.build/en/19077/