Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Trainer.__test_using_best_weights use cloud_io's load to support more storage backends #3694

Merged
merged 10 commits into from
Sep 28, 2020

Conversation

ananthsub
Copy link
Contributor

What does this PR do?

Fixes a bug similar in spirit to #3691. This enables the model checkpoint to store paths to more storage backend systems (S3, GCS, azure, etc), which don't work natively with torch.load(...)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot requested a review from a team September 28, 2020 04:47
@ananthsub ananthsub changed the title Torch load test Make Trainer.__test_using_best_weights use cloud_io's load to support more storage backends Sep 28, 2020
@williamFalcon williamFalcon merged commit 859ec92 into Lightning-AI:master Sep 28, 2020
@Borda Borda added the feature Is an improvement or enhancement label Sep 28, 2020
@Borda Borda added this to the 0.10.0 milestone Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants