Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Trainer.__test_using_best_weights use cloud_io's load to support more storage backends #3694

Merged
merged 10 commits into from
Sep 28, 2020
Merged

Make Trainer.__test_using_best_weights use cloud_io's load to support more storage backends #3694

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4c8cd19
Split out changes from #3563 to make that PR easier to review. This f…
ananthsub Sep 20, 2020
cc636ae
Store a reference to the trainer on the datamodule
ananthsub Sep 27, 2020
fd95161
Update data_connector.py
ananthsub Sep 27, 2020
6513166
Update data_connector.py
ananthsub Sep 27, 2020
0f3c670
Update test_datamodules.py
ananthsub Sep 27, 2020
cc16b35
Merge branch 'trainer-dm'
ananthsub Sep 28, 2020
b56cdef
Merge remote-tracking branch 'upstream/master'
ananthsub Sep 28, 2020
6e4b783
Support more storage backends in trainer.test using best weights
ananthsub Sep 28, 2020
214bfb5
Update trainer.py
ananthsub Sep 28, 2020
3fe2a5e
Update trainer.py
ananthsub Sep 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pytorch_lightning/trainer/trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@
from pytorch_lightning.trainer.connectors.precision_connector import PrecisionConnector
from pytorch_lightning.trainer.connectors.profiler_connector import ProfilerConnector
from pytorch_lightning.trainer.connectors.data_connector import DataConnector
from pytorch_lightning.utilities.cloud_io import load as pl_load
from pytorch_lightning.utilities.model_utils import is_overridden
from pytorch_lightning.trainer import docstrings
from pytorch_lightning.trainer.properties import TrainerProperties
Expand Down Expand Up @@ -569,7 +570,7 @@ def __test_using_best_weights(self, ckpt_path, test_dataloaders):
)
return {}

ckpt = torch.load(ckpt_path, map_location=lambda storage, loc: storage)
ckpt = pl_load(ckpt_path, map_location=lambda storage, loc: storage)
model.load_state_dict(ckpt['state_dict'])

# attach dataloaders
Expand Down