Added a rule for a health check alert (#630) #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #689 +/- ##
=======================================
Coverage 63.33% 63.33%
=======================================
Files 78 78
Lines 5659 5659
=======================================
Hits 3584 3584
Misses 1900 1900
Partials 175 175
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
svetlio8
reviewed
Aug 9, 2022
rokn
force-pushed
the
feature/630-health-check-alert
branch
2 times, most recently
from
ad33bfe to
6d22583
Compare
svetlio8
previously approved these changes
Aug 10, 2022
Psykepro
previously approved these changes
Aug 11, 2022
vectorman1
previously approved these changes
Aug 11, 2022
rokn
force-pushed
the
feature/630-health-check-alert
branch
from
6d22583 to
5e9e73f
Compare
* Fix quote escape problem with Prometheus rules Signed-off-by: Antonio Mindov <[email protected]>
rokn
dismissed stale reviews from vectorman1, Psykepro, and svetlio8
via
276e010
rokn
force-pushed
the
feature/630-health-check-alert
branch
from
5e9e73f to
276e010
Compare
svetlio8
approved these changes
Aug 12, 2022
Psykepro
pushed a commit
that referenced
this pull request
Aug 15, 2022
Signed-off-by: Nikolay Nedkov <[email protected]> Upgrading version of go-ethereum to 'v1.10.21'. Signed-off-by: Nikolay Nedkov <[email protected]> Updating go version to 1.18 Signed-off-by: Nikolay Nedkov <[email protected]> Added a rule for a health check alert (#630) (#689) * Fix quote escape problem with Prometheus rules Signed-off-by: Antonio Mindov <[email protected]> Revert "Updating go version to 1.18" This reverts commit 23b2ec0. Reverting go.mod. Signed-off-by: Nikolay Nedkov <[email protected]> Signed-off-by: Nikolay Nedkov <[email protected]>
Psykepro
pushed a commit
that referenced
this pull request
Aug 19, 2022
* Adding script for bridge deployment automation. (#675) * Adding script for bridge deployment automation. Signed-off-by: Nikolay Nedkov <[email protected]> * Replacing deprecated 'hedera.GeneratePrivateKey' function with 'hedera.PrivateKeyGenerateEd25519'. Signed-off-by: Nikolay Nedkov <[email protected]> * Adding script for extending bridge config for automated bridge setup/… (#686) * Adding script for extending bridge config for automated bridge setup/deploy. Signed-off-by: Nikolay Nedkov <[email protected]> * Fixing import. Signed-off-by: Nikolay Nedkov <[email protected]> * Fixing comments. Signed-off-by: Nikolay Nedkov <[email protected]> * docs: update stale configuration.md (#688) Signed-off-by: Antonio Mindov <[email protected]> * Changing unit to Locale Format for Grafana Balances Panels. (#687) Signed-off-by: Nikolay Nedkov <[email protected]> Signed-off-by: Nikolay Nedkov <[email protected]> * Added a rule for a health check alert (#630) (#689) * Fix quote escape problem with Prometheus rules Signed-off-by: Antonio Mindov <[email protected]> * Adding fix. (#692) Signed-off-by: Nikolay Nedkov <[email protected]> Signed-off-by: Nikolay Nedkov <[email protected]> * Use retry policy values multiplied by seconds (#700) * Use retry policy values multiplied by seconds Signed-off-by: Boris Lachev <[email protected]> * Add tests Signed-off-by: Boris Lachev <[email protected]> Signed-off-by: Boris Lachev <[email protected]> * Adding event handler on bridge config update in 'fee/calculator/servi… (#708) * Adding event handler on bridge config update in 'fee/calculator/service.go'. Signed-off-by: Nikolay Nedkov <[email protected]> * Adding test for bridgeCfgUpdateEventHandler in fee calculator service. Signed-off-by: Nikolay Nedkov <[email protected]> Signed-off-by: Nikolay Nedkov <[email protected]> * Adding gcp logging driver to docker-compose.yml (#693) Signed-off-by: Nikolay Nedkov <[email protected]> Signed-off-by: Nikolay Nedkov <[email protected]> * Changinb to use public RPC urls in æextend-bridge-config.go' (#711) Signed-off-by: Nikolay Nedkov <[email protected]> Signed-off-by: Nikolay Nedkov <[email protected]> Signed-off-by: Nikolay Nedkov <[email protected]> Signed-off-by: Antonio Mindov <[email protected]> Signed-off-by: Boris Lachev <[email protected]> Co-authored-by: Antonio Mindov <[email protected]> Co-authored-by: Boris Lachev <[email protected]>
svetlio8
pushed a commit
that referenced
this pull request
Sep 30, 2022
* Adding script for bridge deployment automation. (#675) * Adding script for bridge deployment automation. Signed-off-by: Nikolay Nedkov <[email protected]> * Replacing deprecated 'hedera.GeneratePrivateKey' function with 'hedera.PrivateKeyGenerateEd25519'. Signed-off-by: Nikolay Nedkov <[email protected]> * Adding script for extending bridge config for automated bridge setup/… (#686) * Adding script for extending bridge config for automated bridge setup/deploy. Signed-off-by: Nikolay Nedkov <[email protected]> * Fixing import. Signed-off-by: Nikolay Nedkov <[email protected]> * Fixing comments. Signed-off-by: Nikolay Nedkov <[email protected]> * docs: update stale configuration.md (#688) Signed-off-by: Antonio Mindov <[email protected]> * Changing unit to Locale Format for Grafana Balances Panels. (#687) Signed-off-by: Nikolay Nedkov <[email protected]> Signed-off-by: Nikolay Nedkov <[email protected]> * Added a rule for a health check alert (#630) (#689) * Fix quote escape problem with Prometheus rules Signed-off-by: Antonio Mindov <[email protected]> * Adding fix. (#692) Signed-off-by: Nikolay Nedkov <[email protected]> Signed-off-by: Nikolay Nedkov <[email protected]> * Use retry policy values multiplied by seconds (#700) * Use retry policy values multiplied by seconds Signed-off-by: Boris Lachev <[email protected]> * Add tests Signed-off-by: Boris Lachev <[email protected]> Signed-off-by: Boris Lachev <[email protected]> * Adding event handler on bridge config update in 'fee/calculator/servi… (#708) * Adding event handler on bridge config update in 'fee/calculator/service.go'. Signed-off-by: Nikolay Nedkov <[email protected]> * Adding test for bridgeCfgUpdateEventHandler in fee calculator service. Signed-off-by: Nikolay Nedkov <[email protected]> Signed-off-by: Nikolay Nedkov <[email protected]> * Adding gcp logging driver to docker-compose.yml (#693) Signed-off-by: Nikolay Nedkov <[email protected]> Signed-off-by: Nikolay Nedkov <[email protected]> * Changinb to use public RPC urls in æextend-bridge-config.go' (#711) Signed-off-by: Nikolay Nedkov <[email protected]> Signed-off-by: Nikolay Nedkov <[email protected]> Signed-off-by: Nikolay Nedkov <[email protected]> Signed-off-by: Antonio Mindov <[email protected]> Signed-off-by: Boris Lachev <[email protected]> Co-authored-by: Antonio Mindov <[email protected]> Co-authored-by: Boris Lachev <[email protected]>
svetlio8
pushed a commit
that referenced
this pull request
Oct 3, 2022
* Adding script for bridge deployment automation. (#675) * Adding script for bridge deployment automation. Signed-off-by: Nikolay Nedkov <[email protected]> * Replacing deprecated 'hedera.GeneratePrivateKey' function with 'hedera.PrivateKeyGenerateEd25519'. Signed-off-by: Nikolay Nedkov <[email protected]> * Adding script for extending bridge config for automated bridge setup/… (#686) * Adding script for extending bridge config for automated bridge setup/deploy. Signed-off-by: Nikolay Nedkov <[email protected]> * Fixing import. Signed-off-by: Nikolay Nedkov <[email protected]> * Fixing comments. Signed-off-by: Nikolay Nedkov <[email protected]> * docs: update stale configuration.md (#688) Signed-off-by: Antonio Mindov <[email protected]> * Changing unit to Locale Format for Grafana Balances Panels. (#687) Signed-off-by: Nikolay Nedkov <[email protected]> Signed-off-by: Nikolay Nedkov <[email protected]> * Added a rule for a health check alert (#630) (#689) * Fix quote escape problem with Prometheus rules Signed-off-by: Antonio Mindov <[email protected]> * Adding fix. (#692) Signed-off-by: Nikolay Nedkov <[email protected]> Signed-off-by: Nikolay Nedkov <[email protected]> * Use retry policy values multiplied by seconds (#700) * Use retry policy values multiplied by seconds Signed-off-by: Boris Lachev <[email protected]> * Add tests Signed-off-by: Boris Lachev <[email protected]> Signed-off-by: Boris Lachev <[email protected]> * Adding event handler on bridge config update in 'fee/calculator/servi… (#708) * Adding event handler on bridge config update in 'fee/calculator/service.go'. Signed-off-by: Nikolay Nedkov <[email protected]> * Adding test for bridgeCfgUpdateEventHandler in fee calculator service. Signed-off-by: Nikolay Nedkov <[email protected]> Signed-off-by: Nikolay Nedkov <[email protected]> * Adding gcp logging driver to docker-compose.yml (#693) Signed-off-by: Nikolay Nedkov <[email protected]> Signed-off-by: Nikolay Nedkov <[email protected]> * Changinb to use public RPC urls in æextend-bridge-config.go' (#711) Signed-off-by: Nikolay Nedkov <[email protected]> Signed-off-by: Nikolay Nedkov <[email protected]> Signed-off-by: Nikolay Nedkov <[email protected]> Signed-off-by: Antonio Mindov <[email protected]> Signed-off-by: Boris Lachev <[email protected]> Co-authored-by: Antonio Mindov <[email protected]> Co-authored-by: Boris Lachev <[email protected]>
Coiling-Dragon
pushed a commit
that referenced
this pull request
Nov 16, 2022
* Adding script for bridge deployment automation. (#675) * Adding script for bridge deployment automation. Signed-off-by: Nikolay Nedkov <[email protected]> * Replacing deprecated 'hedera.GeneratePrivateKey' function with 'hedera.PrivateKeyGenerateEd25519'. Signed-off-by: Nikolay Nedkov <[email protected]> * Adding script for extending bridge config for automated bridge setup/… (#686) * Adding script for extending bridge config for automated bridge setup/deploy. Signed-off-by: Nikolay Nedkov <[email protected]> * Fixing import. Signed-off-by: Nikolay Nedkov <[email protected]> * Fixing comments. Signed-off-by: Nikolay Nedkov <[email protected]> * docs: update stale configuration.md (#688) Signed-off-by: Antonio Mindov <[email protected]> * Changing unit to Locale Format for Grafana Balances Panels. (#687) Signed-off-by: Nikolay Nedkov <[email protected]> Signed-off-by: Nikolay Nedkov <[email protected]> * Added a rule for a health check alert (#630) (#689) * Fix quote escape problem with Prometheus rules Signed-off-by: Antonio Mindov <[email protected]> * Adding fix. (#692) Signed-off-by: Nikolay Nedkov <[email protected]> Signed-off-by: Nikolay Nedkov <[email protected]> * Use retry policy values multiplied by seconds (#700) * Use retry policy values multiplied by seconds Signed-off-by: Boris Lachev <[email protected]> * Add tests Signed-off-by: Boris Lachev <[email protected]> Signed-off-by: Boris Lachev <[email protected]> * Adding event handler on bridge config update in 'fee/calculator/servi… (#708) * Adding event handler on bridge config update in 'fee/calculator/service.go'. Signed-off-by: Nikolay Nedkov <[email protected]> * Adding test for bridgeCfgUpdateEventHandler in fee calculator service. Signed-off-by: Nikolay Nedkov <[email protected]> Signed-off-by: Nikolay Nedkov <[email protected]> * Adding gcp logging driver to docker-compose.yml (#693) Signed-off-by: Nikolay Nedkov <[email protected]> Signed-off-by: Nikolay Nedkov <[email protected]> * Changinb to use public RPC urls in æextend-bridge-config.go' (#711) Signed-off-by: Nikolay Nedkov <[email protected]> Signed-off-by: Nikolay Nedkov <[email protected]> Signed-off-by: Nikolay Nedkov <[email protected]> Signed-off-by: Antonio Mindov <[email protected]> Signed-off-by: Boris Lachev <[email protected]> Co-authored-by: Antonio Mindov <[email protected]> Co-authored-by: Boris Lachev <[email protected]>
Coiling-Dragon
pushed a commit
that referenced
this pull request
Nov 16, 2022
* Adding script for bridge deployment automation. (#675) * Adding script for bridge deployment automation. Signed-off-by: Nikolay Nedkov <[email protected]> * Replacing deprecated 'hedera.GeneratePrivateKey' function with 'hedera.PrivateKeyGenerateEd25519'. Signed-off-by: Nikolay Nedkov <[email protected]> * Adding script for extending bridge config for automated bridge setup/… (#686) * Adding script for extending bridge config for automated bridge setup/deploy. Signed-off-by: Nikolay Nedkov <[email protected]> * Fixing import. Signed-off-by: Nikolay Nedkov <[email protected]> * Fixing comments. Signed-off-by: Nikolay Nedkov <[email protected]> * docs: update stale configuration.md (#688) Signed-off-by: Antonio Mindov <[email protected]> * Changing unit to Locale Format for Grafana Balances Panels. (#687) Signed-off-by: Nikolay Nedkov <[email protected]> Signed-off-by: Nikolay Nedkov <[email protected]> * Added a rule for a health check alert (#630) (#689) * Fix quote escape problem with Prometheus rules Signed-off-by: Antonio Mindov <[email protected]> * Adding fix. (#692) Signed-off-by: Nikolay Nedkov <[email protected]> Signed-off-by: Nikolay Nedkov <[email protected]> * Use retry policy values multiplied by seconds (#700) * Use retry policy values multiplied by seconds Signed-off-by: Boris Lachev <[email protected]> * Add tests Signed-off-by: Boris Lachev <[email protected]> Signed-off-by: Boris Lachev <[email protected]> * Adding event handler on bridge config update in 'fee/calculator/servi… (#708) * Adding event handler on bridge config update in 'fee/calculator/service.go'. Signed-off-by: Nikolay Nedkov <[email protected]> * Adding test for bridgeCfgUpdateEventHandler in fee calculator service. Signed-off-by: Nikolay Nedkov <[email protected]> Signed-off-by: Nikolay Nedkov <[email protected]> * Adding gcp logging driver to docker-compose.yml (#693) Signed-off-by: Nikolay Nedkov <[email protected]> Signed-off-by: Nikolay Nedkov <[email protected]> * Changinb to use public RPC urls in æextend-bridge-config.go' (#711) Signed-off-by: Nikolay Nedkov <[email protected]> Signed-off-by: Nikolay Nedkov <[email protected]> Signed-off-by: Nikolay Nedkov <[email protected]> Signed-off-by: Antonio Mindov <[email protected]> Signed-off-by: Boris Lachev <[email protected]> Co-authored-by: Antonio Mindov <[email protected]> Co-authored-by: Boris Lachev <[email protected]>
Coiling-Dragon
pushed a commit
that referenced
this pull request
Nov 16, 2022
* Adding script for bridge deployment automation. (#675) * Adding script for bridge deployment automation. Signed-off-by: Nikolay Nedkov <[email protected]> * Replacing deprecated 'hedera.GeneratePrivateKey' function with 'hedera.PrivateKeyGenerateEd25519'. Signed-off-by: Nikolay Nedkov <[email protected]> * Adding script for extending bridge config for automated bridge setup/… (#686) * Adding script for extending bridge config for automated bridge setup/deploy. Signed-off-by: Nikolay Nedkov <[email protected]> * Fixing import. Signed-off-by: Nikolay Nedkov <[email protected]> * Fixing comments. Signed-off-by: Nikolay Nedkov <[email protected]> * docs: update stale configuration.md (#688) Signed-off-by: Antonio Mindov <[email protected]> * Changing unit to Locale Format for Grafana Balances Panels. (#687) Signed-off-by: Nikolay Nedkov <[email protected]> Signed-off-by: Nikolay Nedkov <[email protected]> * Added a rule for a health check alert (#630) (#689) * Fix quote escape problem with Prometheus rules Signed-off-by: Antonio Mindov <[email protected]> * Adding fix. (#692) Signed-off-by: Nikolay Nedkov <[email protected]> Signed-off-by: Nikolay Nedkov <[email protected]> * Use retry policy values multiplied by seconds (#700) * Use retry policy values multiplied by seconds Signed-off-by: Boris Lachev <[email protected]> * Add tests Signed-off-by: Boris Lachev <[email protected]> Signed-off-by: Boris Lachev <[email protected]> * Adding event handler on bridge config update in 'fee/calculator/servi… (#708) * Adding event handler on bridge config update in 'fee/calculator/service.go'. Signed-off-by: Nikolay Nedkov <[email protected]> * Adding test for bridgeCfgUpdateEventHandler in fee calculator service. Signed-off-by: Nikolay Nedkov <[email protected]> Signed-off-by: Nikolay Nedkov <[email protected]> * Adding gcp logging driver to docker-compose.yml (#693) Signed-off-by: Nikolay Nedkov <[email protected]> Signed-off-by: Nikolay Nedkov <[email protected]> * Changinb to use public RPC urls in æextend-bridge-config.go' (#711) Signed-off-by: Nikolay Nedkov <[email protected]> Signed-off-by: Nikolay Nedkov <[email protected]> Signed-off-by: Nikolay Nedkov <[email protected]> Signed-off-by: Antonio Mindov <[email protected]> Signed-off-by: Boris Lachev <[email protected]> Co-authored-by: Antonio Mindov <[email protected]> Co-authored-by: Boris Lachev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Antonio Mindov [email protected]
Detailed description:
Adding a rule to Prometheus which will send alerts if the healthy validators fall under a given threshold
Also fixed problem with escaping double quotes in the Prometheus
rules.ymlbecause of$value. This was caused by the wrong pair of quotes being used in the GitHub workflow.Which issue(s) this PR fixes:
Fixes #630
Special notes for your reviewer:
Checklist