Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding event handler on bridge config update in 'fee/calculator/servi… #708

Merged
merged 2 commits into from
Aug 18, 2022

Conversation

Psykepro
Copy link
Contributor

…ce.go'.

Signed-off-by: Nikolay Nedkov [email protected]

Detailed description:

Which issue(s) this PR fixes:
Fixes #707

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

@Psykepro Psykepro requested review from rokn and svetlio8 August 18, 2022 11:14
@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #708 (ecb669e) into main (ff48d77) will increase coverage by 0.00%.
The diff coverage is 70.58%.

@@           Coverage Diff           @@
##             main     #708   +/-   ##
=======================================
  Coverage   63.55%   63.56%           
=======================================
  Files          78       78           
  Lines        5661     5676   +15     
=======================================
+ Hits         3598     3608   +10     
- Misses       1892     1896    +4     
- Partials      171      172    +1     
Flag Coverage Δ
unittests 63.56% <70.58%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/services/fee/calculator/calculator.go 65.62% <70.58%> (+0.91%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

rokn
rokn previously approved these changes Aug 18, 2022
svetlio8
svetlio8 previously approved these changes Aug 18, 2022
Copy link
Collaborator

@svetlio8 svetlio8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Please update also the app/services/fee/calculator/calculator_test.go

@Psykepro Psykepro dismissed stale reviews from svetlio8 and rokn via ecb669e August 18, 2022 13:09
@Psykepro Psykepro requested review from rokn and svetlio8 August 18, 2022 13:09
@Psykepro Psykepro merged commit 9621de3 into main Aug 18, 2022
@Psykepro Psykepro deleted the bugfix/fee-calculator-update-on-config-update branch August 18, 2022 14:41
Psykepro pushed a commit that referenced this pull request Aug 19, 2022
* Adding script for bridge deployment automation. (#675)

* Adding script for bridge deployment automation.

Signed-off-by: Nikolay Nedkov <[email protected]>

* Replacing deprecated 'hedera.GeneratePrivateKey' function with 'hedera.PrivateKeyGenerateEd25519'.

Signed-off-by: Nikolay Nedkov <[email protected]>

* Adding script for extending bridge config for automated bridge setup/… (#686)

* Adding script for extending bridge config for automated bridge setup/deploy.

Signed-off-by: Nikolay Nedkov <[email protected]>

* Fixing import.

Signed-off-by: Nikolay Nedkov <[email protected]>

* Fixing comments.

Signed-off-by: Nikolay Nedkov <[email protected]>

* docs: update stale configuration.md (#688)

Signed-off-by: Antonio Mindov <[email protected]>

* Changing unit to Locale Format for Grafana Balances Panels. (#687)

Signed-off-by: Nikolay Nedkov <[email protected]>

Signed-off-by: Nikolay Nedkov <[email protected]>

* Added a rule for a health check alert (#630) (#689)

* Fix quote escape problem with Prometheus rules

Signed-off-by: Antonio Mindov <[email protected]>

* Adding fix. (#692)

Signed-off-by: Nikolay Nedkov <[email protected]>

Signed-off-by: Nikolay Nedkov <[email protected]>

* Use retry policy values multiplied by seconds (#700)

* Use retry policy values multiplied by seconds

Signed-off-by: Boris Lachev <[email protected]>

* Add tests

Signed-off-by: Boris Lachev <[email protected]>

Signed-off-by: Boris Lachev <[email protected]>

* Adding event handler on bridge config update in 'fee/calculator/servi… (#708)

* Adding event handler on bridge config update in 'fee/calculator/service.go'.

Signed-off-by: Nikolay Nedkov <[email protected]>

* Adding test for bridgeCfgUpdateEventHandler in fee calculator service.

Signed-off-by: Nikolay Nedkov <[email protected]>

Signed-off-by: Nikolay Nedkov <[email protected]>

* Adding gcp logging driver to docker-compose.yml (#693)

Signed-off-by: Nikolay Nedkov <[email protected]>

Signed-off-by: Nikolay Nedkov <[email protected]>

* Changinb to use public RPC urls in æextend-bridge-config.go' (#711)

Signed-off-by: Nikolay Nedkov <[email protected]>

Signed-off-by: Nikolay Nedkov <[email protected]>

Signed-off-by: Nikolay Nedkov <[email protected]>
Signed-off-by: Antonio Mindov <[email protected]>
Signed-off-by: Boris Lachev <[email protected]>
Co-authored-by: Antonio Mindov <[email protected]>
Co-authored-by: Boris Lachev <[email protected]>
svetlio8 pushed a commit that referenced this pull request Sep 30, 2022
* Adding script for bridge deployment automation. (#675)

* Adding script for bridge deployment automation.

Signed-off-by: Nikolay Nedkov <[email protected]>

* Replacing deprecated 'hedera.GeneratePrivateKey' function with 'hedera.PrivateKeyGenerateEd25519'.

Signed-off-by: Nikolay Nedkov <[email protected]>

* Adding script for extending bridge config for automated bridge setup/… (#686)

* Adding script for extending bridge config for automated bridge setup/deploy.

Signed-off-by: Nikolay Nedkov <[email protected]>

* Fixing import.

Signed-off-by: Nikolay Nedkov <[email protected]>

* Fixing comments.

Signed-off-by: Nikolay Nedkov <[email protected]>

* docs: update stale configuration.md (#688)

Signed-off-by: Antonio Mindov <[email protected]>

* Changing unit to Locale Format for Grafana Balances Panels. (#687)

Signed-off-by: Nikolay Nedkov <[email protected]>

Signed-off-by: Nikolay Nedkov <[email protected]>

* Added a rule for a health check alert (#630) (#689)

* Fix quote escape problem with Prometheus rules

Signed-off-by: Antonio Mindov <[email protected]>

* Adding fix. (#692)

Signed-off-by: Nikolay Nedkov <[email protected]>

Signed-off-by: Nikolay Nedkov <[email protected]>

* Use retry policy values multiplied by seconds (#700)

* Use retry policy values multiplied by seconds

Signed-off-by: Boris Lachev <[email protected]>

* Add tests

Signed-off-by: Boris Lachev <[email protected]>

Signed-off-by: Boris Lachev <[email protected]>

* Adding event handler on bridge config update in 'fee/calculator/servi… (#708)

* Adding event handler on bridge config update in 'fee/calculator/service.go'.

Signed-off-by: Nikolay Nedkov <[email protected]>

* Adding test for bridgeCfgUpdateEventHandler in fee calculator service.

Signed-off-by: Nikolay Nedkov <[email protected]>

Signed-off-by: Nikolay Nedkov <[email protected]>

* Adding gcp logging driver to docker-compose.yml (#693)

Signed-off-by: Nikolay Nedkov <[email protected]>

Signed-off-by: Nikolay Nedkov <[email protected]>

* Changinb to use public RPC urls in æextend-bridge-config.go' (#711)

Signed-off-by: Nikolay Nedkov <[email protected]>

Signed-off-by: Nikolay Nedkov <[email protected]>

Signed-off-by: Nikolay Nedkov <[email protected]>
Signed-off-by: Antonio Mindov <[email protected]>
Signed-off-by: Boris Lachev <[email protected]>
Co-authored-by: Antonio Mindov <[email protected]>
Co-authored-by: Boris Lachev <[email protected]>
svetlio8 pushed a commit that referenced this pull request Oct 3, 2022
* Adding script for bridge deployment automation. (#675)

* Adding script for bridge deployment automation.

Signed-off-by: Nikolay Nedkov <[email protected]>

* Replacing deprecated 'hedera.GeneratePrivateKey' function with 'hedera.PrivateKeyGenerateEd25519'.

Signed-off-by: Nikolay Nedkov <[email protected]>

* Adding script for extending bridge config for automated bridge setup/… (#686)

* Adding script for extending bridge config for automated bridge setup/deploy.

Signed-off-by: Nikolay Nedkov <[email protected]>

* Fixing import.

Signed-off-by: Nikolay Nedkov <[email protected]>

* Fixing comments.

Signed-off-by: Nikolay Nedkov <[email protected]>

* docs: update stale configuration.md (#688)

Signed-off-by: Antonio Mindov <[email protected]>

* Changing unit to Locale Format for Grafana Balances Panels. (#687)

Signed-off-by: Nikolay Nedkov <[email protected]>

Signed-off-by: Nikolay Nedkov <[email protected]>

* Added a rule for a health check alert (#630) (#689)

* Fix quote escape problem with Prometheus rules

Signed-off-by: Antonio Mindov <[email protected]>

* Adding fix. (#692)

Signed-off-by: Nikolay Nedkov <[email protected]>

Signed-off-by: Nikolay Nedkov <[email protected]>

* Use retry policy values multiplied by seconds (#700)

* Use retry policy values multiplied by seconds

Signed-off-by: Boris Lachev <[email protected]>

* Add tests

Signed-off-by: Boris Lachev <[email protected]>

Signed-off-by: Boris Lachev <[email protected]>

* Adding event handler on bridge config update in 'fee/calculator/servi… (#708)

* Adding event handler on bridge config update in 'fee/calculator/service.go'.

Signed-off-by: Nikolay Nedkov <[email protected]>

* Adding test for bridgeCfgUpdateEventHandler in fee calculator service.

Signed-off-by: Nikolay Nedkov <[email protected]>

Signed-off-by: Nikolay Nedkov <[email protected]>

* Adding gcp logging driver to docker-compose.yml (#693)

Signed-off-by: Nikolay Nedkov <[email protected]>

Signed-off-by: Nikolay Nedkov <[email protected]>

* Changinb to use public RPC urls in æextend-bridge-config.go' (#711)

Signed-off-by: Nikolay Nedkov <[email protected]>

Signed-off-by: Nikolay Nedkov <[email protected]>

Signed-off-by: Nikolay Nedkov <[email protected]>
Signed-off-by: Antonio Mindov <[email protected]>
Signed-off-by: Boris Lachev <[email protected]>
Co-authored-by: Antonio Mindov <[email protected]>
Co-authored-by: Boris Lachev <[email protected]>
Coiling-Dragon pushed a commit that referenced this pull request Nov 16, 2022
* Adding script for bridge deployment automation. (#675)

* Adding script for bridge deployment automation.

Signed-off-by: Nikolay Nedkov <[email protected]>

* Replacing deprecated 'hedera.GeneratePrivateKey' function with 'hedera.PrivateKeyGenerateEd25519'.

Signed-off-by: Nikolay Nedkov <[email protected]>

* Adding script for extending bridge config for automated bridge setup/… (#686)

* Adding script for extending bridge config for automated bridge setup/deploy.

Signed-off-by: Nikolay Nedkov <[email protected]>

* Fixing import.

Signed-off-by: Nikolay Nedkov <[email protected]>

* Fixing comments.

Signed-off-by: Nikolay Nedkov <[email protected]>

* docs: update stale configuration.md (#688)

Signed-off-by: Antonio Mindov <[email protected]>

* Changing unit to Locale Format for Grafana Balances Panels. (#687)

Signed-off-by: Nikolay Nedkov <[email protected]>

Signed-off-by: Nikolay Nedkov <[email protected]>

* Added a rule for a health check alert (#630) (#689)

* Fix quote escape problem with Prometheus rules

Signed-off-by: Antonio Mindov <[email protected]>

* Adding fix. (#692)

Signed-off-by: Nikolay Nedkov <[email protected]>

Signed-off-by: Nikolay Nedkov <[email protected]>

* Use retry policy values multiplied by seconds (#700)

* Use retry policy values multiplied by seconds

Signed-off-by: Boris Lachev <[email protected]>

* Add tests

Signed-off-by: Boris Lachev <[email protected]>

Signed-off-by: Boris Lachev <[email protected]>

* Adding event handler on bridge config update in 'fee/calculator/servi… (#708)

* Adding event handler on bridge config update in 'fee/calculator/service.go'.

Signed-off-by: Nikolay Nedkov <[email protected]>

* Adding test for bridgeCfgUpdateEventHandler in fee calculator service.

Signed-off-by: Nikolay Nedkov <[email protected]>

Signed-off-by: Nikolay Nedkov <[email protected]>

* Adding gcp logging driver to docker-compose.yml (#693)

Signed-off-by: Nikolay Nedkov <[email protected]>

Signed-off-by: Nikolay Nedkov <[email protected]>

* Changinb to use public RPC urls in æextend-bridge-config.go' (#711)

Signed-off-by: Nikolay Nedkov <[email protected]>

Signed-off-by: Nikolay Nedkov <[email protected]>

Signed-off-by: Nikolay Nedkov <[email protected]>
Signed-off-by: Antonio Mindov <[email protected]>
Signed-off-by: Boris Lachev <[email protected]>
Co-authored-by: Antonio Mindov <[email protected]>
Co-authored-by: Boris Lachev <[email protected]>
Coiling-Dragon pushed a commit that referenced this pull request Nov 16, 2022
* Adding script for bridge deployment automation. (#675)

* Adding script for bridge deployment automation.

Signed-off-by: Nikolay Nedkov <[email protected]>

* Replacing deprecated 'hedera.GeneratePrivateKey' function with 'hedera.PrivateKeyGenerateEd25519'.

Signed-off-by: Nikolay Nedkov <[email protected]>

* Adding script for extending bridge config for automated bridge setup/… (#686)

* Adding script for extending bridge config for automated bridge setup/deploy.

Signed-off-by: Nikolay Nedkov <[email protected]>

* Fixing import.

Signed-off-by: Nikolay Nedkov <[email protected]>

* Fixing comments.

Signed-off-by: Nikolay Nedkov <[email protected]>

* docs: update stale configuration.md (#688)

Signed-off-by: Antonio Mindov <[email protected]>

* Changing unit to Locale Format for Grafana Balances Panels. (#687)

Signed-off-by: Nikolay Nedkov <[email protected]>

Signed-off-by: Nikolay Nedkov <[email protected]>

* Added a rule for a health check alert (#630) (#689)

* Fix quote escape problem with Prometheus rules

Signed-off-by: Antonio Mindov <[email protected]>

* Adding fix. (#692)

Signed-off-by: Nikolay Nedkov <[email protected]>

Signed-off-by: Nikolay Nedkov <[email protected]>

* Use retry policy values multiplied by seconds (#700)

* Use retry policy values multiplied by seconds

Signed-off-by: Boris Lachev <[email protected]>

* Add tests

Signed-off-by: Boris Lachev <[email protected]>

Signed-off-by: Boris Lachev <[email protected]>

* Adding event handler on bridge config update in 'fee/calculator/servi… (#708)

* Adding event handler on bridge config update in 'fee/calculator/service.go'.

Signed-off-by: Nikolay Nedkov <[email protected]>

* Adding test for bridgeCfgUpdateEventHandler in fee calculator service.

Signed-off-by: Nikolay Nedkov <[email protected]>

Signed-off-by: Nikolay Nedkov <[email protected]>

* Adding gcp logging driver to docker-compose.yml (#693)

Signed-off-by: Nikolay Nedkov <[email protected]>

Signed-off-by: Nikolay Nedkov <[email protected]>

* Changinb to use public RPC urls in æextend-bridge-config.go' (#711)

Signed-off-by: Nikolay Nedkov <[email protected]>

Signed-off-by: Nikolay Nedkov <[email protected]>

Signed-off-by: Nikolay Nedkov <[email protected]>
Signed-off-by: Antonio Mindov <[email protected]>
Signed-off-by: Boris Lachev <[email protected]>
Co-authored-by: Antonio Mindov <[email protected]>
Co-authored-by: Boris Lachev <[email protected]>
Coiling-Dragon pushed a commit that referenced this pull request Nov 16, 2022
* Adding script for bridge deployment automation. (#675)

* Adding script for bridge deployment automation.

Signed-off-by: Nikolay Nedkov <[email protected]>

* Replacing deprecated 'hedera.GeneratePrivateKey' function with 'hedera.PrivateKeyGenerateEd25519'.

Signed-off-by: Nikolay Nedkov <[email protected]>

* Adding script for extending bridge config for automated bridge setup/… (#686)

* Adding script for extending bridge config for automated bridge setup/deploy.

Signed-off-by: Nikolay Nedkov <[email protected]>

* Fixing import.

Signed-off-by: Nikolay Nedkov <[email protected]>

* Fixing comments.

Signed-off-by: Nikolay Nedkov <[email protected]>

* docs: update stale configuration.md (#688)

Signed-off-by: Antonio Mindov <[email protected]>

* Changing unit to Locale Format for Grafana Balances Panels. (#687)

Signed-off-by: Nikolay Nedkov <[email protected]>

Signed-off-by: Nikolay Nedkov <[email protected]>

* Added a rule for a health check alert (#630) (#689)

* Fix quote escape problem with Prometheus rules

Signed-off-by: Antonio Mindov <[email protected]>

* Adding fix. (#692)

Signed-off-by: Nikolay Nedkov <[email protected]>

Signed-off-by: Nikolay Nedkov <[email protected]>

* Use retry policy values multiplied by seconds (#700)

* Use retry policy values multiplied by seconds

Signed-off-by: Boris Lachev <[email protected]>

* Add tests

Signed-off-by: Boris Lachev <[email protected]>

Signed-off-by: Boris Lachev <[email protected]>

* Adding event handler on bridge config update in 'fee/calculator/servi… (#708)

* Adding event handler on bridge config update in 'fee/calculator/service.go'.

Signed-off-by: Nikolay Nedkov <[email protected]>

* Adding test for bridgeCfgUpdateEventHandler in fee calculator service.

Signed-off-by: Nikolay Nedkov <[email protected]>

Signed-off-by: Nikolay Nedkov <[email protected]>

* Adding gcp logging driver to docker-compose.yml (#693)

Signed-off-by: Nikolay Nedkov <[email protected]>

Signed-off-by: Nikolay Nedkov <[email protected]>

* Changinb to use public RPC urls in æextend-bridge-config.go' (#711)

Signed-off-by: Nikolay Nedkov <[email protected]>

Signed-off-by: Nikolay Nedkov <[email protected]>

Signed-off-by: Nikolay Nedkov <[email protected]>
Signed-off-by: Antonio Mindov <[email protected]>
Signed-off-by: Boris Lachev <[email protected]>
Co-authored-by: Antonio Mindov <[email protected]>
Co-authored-by: Boris Lachev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Fee Calculator service updating on loading bridge config from topic
3 participants