Merge pull request #5457 from LiskHQ/5278-genesis-block-processor

Create BlockProcessorV0 which handles the genesis block - Closes #5278
LiskArchive · Jun 24, 2020 · 580080b · 580080b
2 parents f9cdba3 + f34f9d8
commit 580080b
Show file tree

Hide file tree

Showing 38 changed files with 7,125 additions and 12,575 deletions.
diff --git a/elements/lisk-bft/src/bft.ts b/elements/lisk-bft/src/bft.ts
@@ -227,7 +227,7 @@ export class BFT extends EventEmitter {
 
 		const finalizedHeightStored =
 			storedFinalizedHeightBuffer === undefined
-				? 1
+				? 0
 				: codec.decode<BFTPersistedValues>(
 						BFTFinalizedHeightCodecSchema,
 						storedFinalizedHeightBuffer,

diff --git a/elements/lisk-chain/src/chain.ts b/elements/lisk-chain/src/chain.ts
@@ -41,7 +41,6 @@ import { DataAccess } from './data_access';
 import { Slots } from './slots';
 import { StateStore } from './state_store';
 import {
-	applyGenesisTransactions,
 	applyTransactions,
 	checkAllowedTransactions,
 	undoTransactions,
@@ -222,7 +221,9 @@ export class Chain {
 		// Check mem tables
 		let genesisBlock: BlockHeader;
 		try {
-			genesisBlock = await this.dataAccess.getBlockHeaderByHeight(1);
+			genesisBlock = await this.dataAccess.getBlockHeaderByID(
+				this.genesisBlock.header.id,
+			);
 		} catch (error) {
 			throw new Error('Failed to load genesis block');
 		}
@@ -253,7 +254,7 @@ export class Chain {
 
 	public async newStateStore(skipLastHeights = 0): Promise<StateStore> {
 		const fromHeight = Math.max(
-			1,
+			0,
 			this._lastBlock.header.height -
 				this.constants.stateBlockSize -
 				skipLastHeights,
@@ -363,15 +364,6 @@ export class Chain {
 		await applyFeeAndRewards(block, stateStore);
 	}
 
-	// eslint-disable-next-line class-methods-use-this
-	public async applyGenesis(
-		block: Block,
-		stateStore: StateStore,
-	): Promise<void> {
-		await applyGenesisTransactions(block.payload, stateStore);
-		await applyFeeAndRewards(block, stateStore);
-	}
-
 	public async save(
 		block: Block,
 		stateStore: StateStore,
@@ -416,7 +408,7 @@ export class Chain {
 		stateStore: StateStore,
 		{ saveTempBlock } = { saveTempBlock: false },
 	): Promise<void> {
-		if (block.header.height === 1) {
+		if (block.header.version === this.genesisBlock.header.version) {
 			throw new Error('Cannot delete genesis block');
 		}
 		let secondLastBlock: Block;
@@ -533,7 +525,7 @@ export class Chain {
 		// Cache the block headers (size=DEFAULT_MAX_BLOCK_HEADER_CACHE)
 		const fromHeight = Math.max(
 			storageLastBlock.header.height - DEFAULT_MAX_BLOCK_HEADER_CACHE,
-			1,
+			0,
 		);
 		const toHeight = storageLastBlock.header.height;
 

diff --git a/elements/lisk-chain/src/transactions/index.ts b/elements/lisk-chain/src/transactions/index.ts
@@ -17,5 +17,4 @@ export {
 	applyTransactions,
 	checkAllowedTransactions,
 	undoTransactions,
-	applyGenesisTransactions,
 } from './transactions_handlers';
diff --git a/elements/lisk-chain/src/transactions/transactions_handlers.ts b/elements/lisk-chain/src/transactions/transactions_handlers.ts
@@ -20,34 +20,13 @@ import {
 } from '@liskhq/lisk-transactions';
 
 import { StateStore } from '../state_store';
-import {
-	Contexter,
-	MatcherTransaction,
-	WriteableTransactionResponse,
-} from '../types';
+import { Contexter, MatcherTransaction } from '../types';
 
 export const validateTransactions = (
 	transactions: ReadonlyArray<BaseTransaction>,
 ): ReadonlyArray<TransactionResponse> =>
 	transactions.map(transaction => transaction.validate());
 
-export const applyGenesisTransactions = async (
-	transactions: ReadonlyArray<BaseTransaction>,
-	stateStore: StateStore,
-): Promise<TransactionResponse[]> => {
-	const transactionsResponses: TransactionResponse[] = [];
-	for (const transaction of transactions) {
-		const transactionResponse = await transaction.apply(stateStore);
-
-		// We are overriding the status of transaction because it's from genesis block
-		(transactionResponse as WriteableTransactionResponse).status =
-			TransactionStatus.OK;
-		transactionsResponses.push(transactionResponse);
-	}
-
-	return transactionsResponses;
-};
-
 export const applyTransactions = async (
 	transactions: ReadonlyArray<BaseTransaction>,
 	stateStore: StateStore,

diff --git a/elements/lisk-chain/src/validate.ts b/elements/lisk-chain/src/validate.ts
@@ -47,13 +47,10 @@ export const validatePreviousBlockProperty = (
 ): void => {
 	const isGenesisBlock =
 		block.header.id.equals(genesisBlock.header.id) &&
-		block.header.previousBlockID.length === 0 &&
-		block.header.height === 1;
+		block.header.version === 0;
 	const propertyIsValid =
 		isGenesisBlock ||
-		(!block.header.id.equals(genesisBlock.header.id) &&
-			block.header.previousBlockID.length > 0 &&
-			block.header.height !== 1);
+		(block.header.previousBlockID.length > 0 && block.header.version !== 0);
 
 	if (!propertyIsValid) {
 		throw new Error('Invalid previous block');