This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Create BlockProcessorV0 which handles the genesis block - Closes #5278 #5457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazarhussain
changed the base branch from
feature/new-genesis-integration
to
development
nazarhussain
changed the base branch from
development
to
feature/new-genesis-integration
|
@shuse2 @ManuGowda Please review the PR, meanwhile I will fix the tests. |
shuse2
suggested changes
Jun 23, 2020
| @@ -123,7 +123,14 @@ export const validateGenesisBlock = ( | |||
| accountAddresses.push(account.address); | |||
| totalBalance += BigInt(account.balance); | |||
|
|
|||
| if (account.asset.delegate.username !== '') { | |||
| // TODO: Find better way to specify generic type to make delgate asset required | |||
There was a problem hiding this comment.
Agree, this should be more generic and ideally genesis block shouldn't know about the asset field
ManuGowda
approved these changes
Jun 23, 2020
…-sdk into 5278-genesis-block-processor
shuse2
suggested changes
Jun 24, 2020
ManuGowda
approved these changes
Jun 24, 2020
shuse2
approved these changes
Jun 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #5278
How was it solved?
Created new block processor for version zero.
How was it tested?