Merge pull request #6905 from LiskHQ/6887-update_bft_api

Update aggregate commit empty condition - Closes #6887
LiskArchive · Nov 19, 2021 · ecda816 · ecda816
2 parents 4b1bf5c + 356ddf8
commit ecda816
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/framework/src/modules/bft/bft_votes.ts b/framework/src/modules/bft/bft_votes.ts
@@ -163,7 +163,6 @@ export const updateMaxHeightPrecommitted = async (
 
 export const updateMaxHeightCertified = (bftVotes: BFTVotes, header: BlockHeader): void => {
 	if (
-		header.aggregateCommit.height === 0 &&
 		header.aggregateCommit.aggregationBits.length === 0 &&
 		header.aggregateCommit.certificateSignature.length === 0
 	) {

diff --git a/framework/test/unit/modules/bft/bft_votes.spec.ts b/framework/test/unit/modules/bft/bft_votes.spec.ts
@@ -486,7 +486,7 @@ describe('BFT votes', () => {
 					aggregateCommit: {
 						aggregationBits: Buffer.alloc(0),
 						certificateSignature: Buffer.alloc(0),
-						height: 0,
+						height: 10,
 					},
 				}),
 			);