Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update aggregate commit verification in bft module #6887

Closed
Tracked by #6742
shuse2 opened this issue Nov 5, 2021 · 0 comments
Closed
Tracked by #6742

Update aggregate commit verification in bft module #6887

shuse2 opened this issue Nov 5, 2021 · 0 comments
Assignees
@shuse2
Labels
framework unplanned
Milestone
Sprint 57

Comments

@shuse2
Copy link
Collaborator

shuse2 commented Nov 5, 2021

Description

Update condition to check aggregate commits to be below.
Specifically, height condition is removed.

Let `m` be the aggregate commit included in block `b`. If `m.aggregationBits` is empty bytes and `m.signature` is empty bytes, do nothing.

Acceptance Criteria

  • Unit test is updated
@sridharmeganathan sridharmeganathan mentioned this issue Nov 8, 2021
Closed
36 tasks
@shuse2 shuse2 self-assigned this Nov 12, 2021
@shuse2 shuse2 added this to the Sprint 57 milestone Nov 12, 2021
@shuse2 shuse2 mentioned this issue Nov 12, 2021
Merged
shuse2 added a commit that referenced this issue Nov 19, 2021
@shuse2
Merge pull request #6905 from LiskHQ/6887-update_bft_api
ecda816 
Update aggregate commit empty condition - Closes #6887
@shuse2 shuse2 closed this as completed Nov 19, 2021
@shuse2 shuse2 mentioned this issue Nov 22, 2021
Closed
8 tasks
@shuse2 shuse2 moved this to Done in Lisk SDK Version 6.0.0 Jan 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@shuse2 shuse2

Labels
framework unplanned
Projects
None yet
Milestone
Sprint 57
Development

No branches or pull requests
1 participant
@shuse2