Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update plugin to use IPC endpoint instead of channel between application #7133

Closed
Tracked by #7011
shuse2 opened this issue Apr 22, 2022 · 1 comment · Fixed by #7184
Closed
Tracked by #7011

Update plugin to use IPC endpoint instead of channel between application #7133

shuse2 opened this issue Apr 22, 2022 · 1 comment · Fixed by #7184

Comments

@shuse2
Copy link
Collaborator

shuse2 commented Apr 22, 2022

Description

  • Update application to throw error if IPC is not enabled and plugin is registered
  • Update plugin to use API client to connect to the RPC endpoint given by the config
  • Remove events from the plugin

Acceptance Criteria

  • All tests for the plugin should be passing
@shuse2
Copy link
Collaborator Author

shuse2 commented May 24, 2022

Additional update required

  1. Add missing endpoints
    • network_getStats (previously app_)
    • network_getConnectedPeers (previously app_)
    • network_getDisconnectedPeers (previously app_)
    • chain_getTransactionsByHeight (required if only broadcast header)
    • chain_getAssetsByHeight (required if only broadcast header)
    • system_getSchema (required to return block/transaction/asset schema for decoding)
  2. Add/Update RPC event name
    • txpool_newTransaction (previously app_)
    • chain_newBlock (update to only broadcast header)
    • chain_deleteBlock (update to only broadcast header)
    • chain_forked (update to only broadcast header)
    • chain_validatorUpdate
    • network_newBlock (New event replacing app_networkEvent)
  3. Consider adding engine start endpoint (no hook to run controller)
    • Add abi:ready
  4. Update @liskhq/lisk-api-client to use metadata, schema and new endpoints
  5. Update all RPC to return in JSON object to be consistent with module endpoints

@shuse2 shuse2 linked a pull request May 27, 2022 that will close this issue
@shuse2 shuse2 moved this from In Progress to Pending Review in Lisk SDK Version 6.0.0 May 27, 2022
shuse2 added a commit that referenced this issue Jun 3, 2022
Update plugins to use IPC RPC server - Closes #7133
Repository owner moved this from Pending Review to Done in Lisk SDK Version 6.0.0 Jun 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.