Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update plugins to use IPC RPC server - Closes #7133 #7184

Merged
merged 5 commits into from
Jun 3, 2022
Merged

Update plugins to use IPC RPC server - Closes #7133 #7184

merged 5 commits into from
Jun 3, 2022

Conversation

shuse2
Copy link
Collaborator

@shuse2 shuse2 commented May 27, 2022

What was the problem?

This PR resolves #7133

How was it solved?

  • Fix RPC server implementation
  • Fix RPC server events
  • Update RPC definitions
  • Update APIClient to the latest structure
    • Update to use metadata/schema
    • Update the expected reply from RPC server
  • Update transaction library to accept undefined schema

How was it tested?

  • Update all the tests
  • Use example dpos app to run with plugins, such as report misbehavior command

@shuse2 shuse2 self-assigned this May 27, 2022
@shuse2 shuse2 linked an issue May 27, 2022 that may be closed by this pull request
Update plugin to use IPC endpoint instead of channel between application #7133
Closed
shuse2
shuse2 commented May 30, 2022
View reviewed changes
elements/lisk-api-client/src/api_client.ts Show resolved Hide resolved
elements/lisk-transactions/src/sign.ts Show resolved Hide resolved
framework/src/engine/endpoint/txpool.ts Show resolved Hide resolved
framework/src/engine/engine.ts Show resolved Hide resolved
framework/src/engine/engine.ts Show resolved Hide resolved
framework/src/controller/child_process_loader.ts Show resolved Hide resolved
@shuse2 shuse2 requested review from Incede and ishantiw June 1, 2022 06:25
@shuse2 shuse2 force-pushed the 7131-update_folder_name branch from 5e115ab to 59dd0a7 Compare June 2, 2022 11:45
Base automatically changed from 7131-update_folder_name to feature/7011-improve_sdk_performance June 2, 2022 12:34
@shuse2 shuse2 force-pushed the 7133-update_plugins branch from dc2ca4f to 913f2dc Compare June 2, 2022 12:40
ishantiw
ishantiw reviewed Jun 3, 2022
View reviewed changes
Copy link
Contributor

@ishantiw ishantiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few comments

elements/lisk-api-client/src/types.ts Show resolved Hide resolved
framework-plugins/lisk-framework-dashboard-plugin/src/ui/pages/MainPage.tsx Outdated Show resolved Hide resolved
framework-plugins/lisk-framework-monitor-plugin/src/controllers/prometheus.ts Outdated Show resolved Hide resolved
framework-plugins/lisk-framework-monitor-plugin/test/unit/prometheus.spec.ts Outdated Show resolved Hide resolved
@shuse2 shuse2 requested a review from ishantiw June 3, 2022 14:53
ishantiw
ishantiw approved these changes Jun 3, 2022
View reviewed changes
Copy link
Contributor

@ishantiw ishantiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@shuse2 shuse2 merged commit 1057d81 into feature/7011-improve_sdk_performance Jun 3, 2022
@shuse2 shuse2 deleted the 7133-update_plugins branch June 3, 2022 15:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ishantiw ishantiw ishantiw approved these changes

@Incede Incede Incede approved these changes

Assignees

@shuse2 shuse2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update plugin to use IPC endpoint instead of channel between application
3 participants
@shuse2 @ishantiw @Incede