Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate user retries on pod setup resumes (Loop issue #2117 follow up) #114

Merged
merged 3 commits into from
Apr 2, 2024
Merged

Eliminate user retries on pod setup resumes (Loop issue #2117 follow up) #114

merged 3 commits into from
Apr 2, 2024

Conversation

itsmojo
Copy link

@itsmojo itsmojo commented Mar 8, 2024

  • Have PairAndPrime ViewModel do an automatic retry on error
  • Have InsertCannula ViewModel do an automatic retry on error
  • Add resumingPodSetup func to attempt a getStatus and sleep on errors
  • Added some improved and updated pumpManager comments
  • Have pumpManager detect pod setup resumes to invoke resumingPodSetup()
  • Include additional isConnected handling to OmniBLE resumingPodSetup()

itsmojo added 3 commits March 7, 2024 23:57
+ Have PairAndPrime ViewModel do an automatic retry on error
+ Have InsertCannula ViewModel do an automatic retry on error
+ Add resumingPodSetup func to attempt a getStatus and sleep on errors
+ Added some improved and updated pumpManager comments
+ Have pumpManager detect pod setup resumes to invoke resumingPodSetup()
+ Include additional isConnected handling to OmniBLE resumingPodSetup()
@marionbarker
Copy link
Collaborator

I did a code review and tested this PR.
It is successful.

Background:
With the previous PR, there were several times when a retry was required to get the setup process to continue.
See: #113 (comment)

Since the testing for PR 113, the rPi code was updated (when using PR 11 for that code), so the rPi simulator waits for priming and insertion to complete before progressing to the new pod state.

Therefore, this PR can be tested using just the rPI DASH simulator.

Test:
This code behaved nominally when resuming following

  • Quit and restart once priming had begun
    • Repeated the process during the priming and after priming completed
  • Quit and restart once the insert cannula bolus had begun
    • Repeated the process during the insertion bolus and after bolus completed

I repeated the pairing and inserting several times, since I can use the rPi DASH. Every time I returned to the pod menu, the process continued without needing to retry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants