Prevent hang following restart if Pod Setup was interrupted #122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During testing, we discovered a rare case where Loop would hang following a quit/restart during the Pod Setup process.
The hang was noticed a few times out of dozens of tests - hard to reproduce with random swiping to quit Loop.
We identified how to reproduce the case and solved it with this PR.
Steps to reproduce the hang (with rPi and dev commit 130c6d5):
fix_restart_hang
branch instead ofdev
Repeated this test with a DASH pod.
Same result - if paused and restarted app after the 0x03 command was issued, the infinite wait was observed with dev commit 130c6d5.
Rebuilt again with fix_restart_hang (commit e58045f), the pod continued to priming and to insertion.