TR2X bug: visible overlap of rooms in The Deck

[aredfan]

Regression since: 0.6

---

Steps to reproduce:

1. /play 10
2. /tp 51 4 48
3. move the camera until you can see the rooms overlapping

[lahm86]

This is a strange one. It seems like a data issue - room 17 has a visibility portal into room 104 (which is clearly wrong, must have been a level editing bug), and in turn because that is linked to room 80, room 80 is drawn. The portal is marked by the waypoints here, just imagine it pointing downwards to room 104.

I'm not sure where the regression is if this doesn't happen in OG. Ideally we would fix the data and the regression itself.

[aredfan]

Thanks for providing a detailed breakdown there Lahm.

Btw this issue also manifests in the upper end of the level where Lara picks up the last key.

[lahm86]

This seems to have been caused by 6c36549. Restoring the various g_FltWinLeft = g_PhdWinMinX; //...etc calls in output.c that were removed in that commit fixes it, but there are side effects:

• Restoring in Output_InsertRoom fixes the main problem, but 3D pickups aren't shown in-game, and the inventory is empty.
• Restoring in Output_InsertRoom and Output_InsertPolygons fixes the problem and pickup/inventory display, but the 3D pickups appear centre-screen.