Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OG bug: room 98 is dry despite having a shark in it | Wreck of the Maria Doria #1939

Closed
aredfan opened this issue Nov 24, 2024 · 0 comments · Fixed by #1970
Closed

OG bug: room 98 is dry despite having a shark in it | Wreck of the Maria Doria #1939

aredfan opened this issue Nov 24, 2024 · 0 comments · Fixed by #1970
Assignees
@lahm86
Labels
Data Requires injecting content / files that are not a part of the original game OG bug A bug in original game TR2

Comments

@aredfan
Copy link
Collaborator

aredfan commented Nov 24, 2024

I came across this issue while investigating #1936.

In Wreck of the Maria Doria, a room containing a shark has no water in it. This may explain why the shark is alive in TR2X versions prior to 0.3 whereas other sharks were already dead upon level load.

Screenshot

I made this video as proof of concept of what the room would look like from above if the water effect is fixed. First half is OG and the second half is a modified level. The fixed water effect is an improvement to what may be a dev oversight.

VIdeo.mp4

I've tested the modified level in HW and SW modes and found no graphical issues. If it's possible to introduce this fix via injection then that'd be great. Thank you for taking the time to read this issue and for considering it.
@aredfan aredfan added OG bug A bug in original game Data Requires injecting content / files that are not a part of the original game TR2 labels Nov 24, 2024
@lahm86 lahm86 moved this to Ready in TRX Dev tracker Nov 24, 2024
@lahm86 lahm86 moved this from Ready to Backlog in TRX Dev tracker Nov 24, 2024
@lahm86 lahm86 mentioned this issue Nov 28, 2024
Open
16 tasks
@lahm86 lahm86 self-assigned this Nov 28, 2024
@lahm86 lahm86 moved this from Backlog to In progress in TRX Dev tracker Nov 28, 2024
lahm86 added a commit to lahm86/TRX that referenced this issue Nov 28, 2024
@lahm86
tr2/data: fix dry shark room in Wreck
3905910 
This floods room 98 in Wreck of the Maria Doria.

Resolves LostArtefacts#1939.
@lahm86 lahm86 mentioned this issue Nov 28, 2024
Merged
2 tasks
lahm86 added a commit that referenced this issue Nov 28, 2024
@lahm86
tr2/data: fix dry shark room in Wreck
67a7531 
This floods room 98 in Wreck of the Maria Doria.

Resolves #1939.
@github-project-automation github-project-automation bot moved this from In progress to Done in TRX Dev tracker Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lahm86 lahm86

Labels
Data Requires injecting content / files that are not a part of the original game OG bug A bug in original game TR2
Projects
TRX Dev tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tr2/inject: add item and room editing support lahm86/TRX
2 participants
@lahm86 @aredfan