-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove DB migrations that rely on rmp_serde
#306
Labels
breaking
Requires a breaking change
Comments
3 tasks
LucasPickering
added a commit
that referenced
this issue
Dec 31, 2024
This removes a ton of code that was effectively dead. The migration now provides some help for users trying to go directly from <1.8.0 to 3.0.0. Closes #306
LucasPickering
added a commit
that referenced
this issue
Dec 31, 2024
This removes a ton of code that was effectively dead. The migration now provides some help for users trying to go directly from <1.8.0 to 3.0.0. Closes #306
LucasPickering
added a commit
that referenced
this issue
Dec 31, 2024
This removes a ton of code that was effectively dead. The migration now provides some help for users trying to go directly from <1.8.0 to 3.0.0. Closes #306
LucasPickering
added a commit
that referenced
this issue
Jan 1, 2025
This removes a ton of code that was effectively dead. The migration now provides some help for users trying to go directly from <1.8.0 to 3.0.0. Closes #306
LucasPickering
added a commit
that referenced
this issue
Jan 2, 2025
This removes a ton of code that was effectively dead. The migration now provides some help for users trying to go directly from <1.8.0 to 3.0.0. Closes #306
LucasPickering
added a commit
that referenced
this issue
Jan 2, 2025
This removes a ton of code that was effectively dead. The migration now provides some help for users trying to go directly from <1.8.0 to 3.0.0. Closes #306
LucasPickering
added a commit
that referenced
this issue
Jan 4, 2025
This removes a ton of code that was effectively dead. The migration now provides some help for users trying to go directly from <1.8.0 to 3.0.0. Closes #306
LucasPickering
added a commit
that referenced
this issue
Jan 6, 2025
This removes a ton of code that was effectively dead. The migration now provides some help for users trying to go directly from <1.8.0 to 3.0.0. Closes #306
LucasPickering
added a commit
that referenced
this issue
Jan 7, 2025
This removes a ton of code that was effectively dead. The migration now provides some help for users trying to go directly from <1.8.0 to 3.0.0. Closes #306
LucasPickering
added a commit
that referenced
this issue
Jan 14, 2025
This removes a ton of code that was effectively dead. The migration now provides some help for users trying to go directly from <1.8.0 to 3.0.0. Closes #306
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the past, Slumber encoded a lot of data in the sqlite DB as msgpack. This was a quick and dirty solution I used to easily shove stuff in there while I was iterating, and I didn't think too much about the impacts. #308 added a few migrations to move away from that. Unfortunately we still have
rmp_serde
in the dep tree because it's needed for the data migrations. As users upgrade to the version that included the migrations (should be 1.8.0), the need for that code will reduce over time. Eventually I would like to cut them out completely, which will eliminate a lot of code. It'll especially take out a good amount of serde codegen, which should help compile times a bit.Removing the migrations will be a breaking change, so that will most likely be 2.0.0. Once the migrations are removed, anyone on <1.8.0 will have to upgrade to something >=1.8.0 <2.0.0 before going to 2.0.0. We'll need a small workflow to provide error messages if someone tries to make the big jump. I think a good waiting period before 2.0.0 would be about 6 months, so ~February 2025.
The text was updated successfully, but these errors were encountered: