Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the change. If there is an associated issue, please include the issue link (e.g. "Closes #xxx"). For UI changes, please also include screenshots.
This removes a ton of code that was effectively dead. The migration now provides some help for users trying to go directly from <1.8.0 to 3.0.0.
Closes #306
Known Risks
What issues could potentially go wrong with this change? Is it a breaking change? What have you done to mitigate any potential risks?
There's reasonable risk here. My hope is that almost everyone using the tool has upgraded to 1.8.0 or later already, in which case this will have no impact for them.
QA
How did you test this?
I started writing some unit tests, but I couldn't figure out a way to mock the dialog interaction. Since this is one-time code that will never need to be changed again, there isn't a huge amount of value in unit testing anyway.
Instead, I tested the 4 possible scenarios manually:
Checklist
CONTRIBUTING.md
already?CHANGELOG.md
?