-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugs and Small Improvement Request #336
Comments
Try to give you short feedback. First of all thanks for taking your time to report in such detail. Since many issues affect mobile experience, I have to ask you if you can provide your device information especially your display resolution, because some stuff sounds to me, that you targeted a very niché spot with your device.
The button is a simple
This is definetly already the case, but the device width is currently set to
I will optimize sizing and make the space scrollable on overflow.
I will take a look.
I am unsure about this, because there are many thinks that may not be intuitive and you just need to learn. If you once knew it, it just looks cleaner and easier then always having a big text button on this view. But we can discuss on that.
The
I think adding an indicator about how many loot cards are looted by the char is a first good improvement will do that. On the other stuff I am still unsure. For maintaining reasons I already stated out somewhere that I don't want to change too much stuff between editions, so that's always a trade-off.
Interesting, cannot imagine that images are too small to identify, but your request shouldn't be much work either, so maybe just implement it. As stated above, happy about your screen dimensions and zoom level...
You mean the buttons of the input fields? That is build in from browser, so honestly I am unsure if I will touch those. Also it should be numeric input, so you can also just click on the field and change number directly. I want to keep the style of the original sheet as much as possible.
Same as party sheet, don't want to touch too much on the sheet itself. Already make the boxes much bigger to be accessible on mobile. Putting it in multiple lines will create even more scrolling which I don't like.
For that one, you have to thank other user, which requested this in #210.
Haha thanks. |
Already handled some small stuff in v0.67.9. Happy about more feedback. |
For the Feedback, the message was probably too long since I was trying to send this there. My mobile is Nokia X10, it does have a bigger screen size than most. For the Avatar one, I think I didn't make it clear. I hope to see the full picture of the monster, but not just a enlarged circle. Thanks!! I will check the changes!! |
Haha okay, for many monsters, I don't have other pictures. |
Added monster artwork I could extract from TTS in v0.68.4 Hope that's what you meant. |
I have another run with my friends last weekend! I love all the changes! I know it is my fault. With the enlarged artwork added, now it becomes quite hard to drag the order around. Also it seems the adding items on character sheets look entirely different on Android(Firefox) and iOS(Safari), I haven't confirm this with more iPhones yet. |
Weird, can you provide screenshots? I added setting to disable "portrait mode optimization" caused by changes here. Also possible that versions do not match? Anyways, regarding the artwork and drag'n'drop, I will change artwork popping up only after release the long press, so you have "endless" time to decide for dragging or artwork, hope that works out and fixes that issue. |
…iate range hints, small other fixes and improvements
Would you consider an option to change between "classic" sheets and a "digital" one? A design like the Gloomhaven Companion's might be preferable for many people.
The loot indicator could be toggled based on Loot Deck presence, which is already different between editions. It also makes much more sense to have a loot card indicator than a coin indicator when you have loot
I also think the big text button is unclean. I think a skull and a "Zzz" button next to 0 would be best, for exhausting and long resting. Would also mean changing the in-round exhaust button to a skull, which I believe makes more sense |
Yeah this sounds like a good idea. Biggest issue for me: UX. I am really bad and if I design a digital version myself, everyone will still prefer the classical sheet 😅 . So if anyone open for proposals, go for it.
Yes, for FH you're right, would make more sense to track the coin loot as other resources. I will think about it.
Haha, this was just request in this ticket and I did this. So you're more asking about reverting the change. I don't care that much about that small button, so I am fine to keep it as it is for better readability because there is no official iconography for such things and I defined those myself, it may be easier. |
The app I mentioned, Gloomhaven Companion, has a decent enough interface. I don't think it is open, but should be feasible to copy.
I was just agreeing with you, since you said you were unsure about it. It is not a big deal, indeed. |
Since most of the stuff is implemented, I will close this issue and create a separate issue for creating alternate sheets. |
Thank you for making this amazing app! Since you are so active in taking feedback (on Reddit and BGG) I guess I might share some of my suggestion with you! Below are a bunch of nitpicking for you to waste more time in this non-profitable but hopefully fun project.
Feedback
Setting
UI - General
UI - Party Sheet
UI - Character Sheet
Other
Thank you for this amazing web app!! LOVE YOU!!!!!!!!!! I have tried x-haven but I think GS is much more appealing visually and it is an absolute priority for me! Glad we have so many amazing, humble and talented people willing to pick up the legacy of GHH. I would give you a huge kiss if I can. May you loot all the coins in the loot deck.
The text was updated successfully, but these errors were encountered: