Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: tempdir cleanup #2681

Closed
tylerjereddy opened this issue May 14, 2020 · 0 comments · Fixed by #2682
Closed

MAINT: tempdir cleanup #2681

tylerjereddy opened this issue May 14, 2020 · 0 comments · Fixed by #2682
Assignees
@tylerjereddy
Labels
maintainability testing

Comments

@tylerjereddy
Copy link
Member

As discussed in #2680, we can probably remove testsuite/MDAnalysisTests/tempdir.py, preferring the upstream implementation in pytest tmpdir over maintaining our own.

This should be a fairly straightforward migration--just double check there are no testing artifacts left over after running the full suite locally.

I can probably do this soon-ish..
@tylerjereddy tylerjereddy mentioned this issue May 14, 2020
Merged
4 tasks
orbeckst added a commit that referenced this issue May 15, 2020
@tylerjereddy @orbeckst
MAINT, TST: remove tempdir (#2682)
375245c 
* Fixes #2681
* use the upstream `pytest` temporary file/path handling instead of using/maintaining our own
* no residual test artifacts were observed when the full test suite passed locally for this feature branch

Co-authored-by: Oliver Beckstein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tylerjereddy tylerjereddy

Labels
maintainability testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MAINT, TST: remove tempdir tylerjereddy/mdanalysis
1 participant
@tylerjereddy