MAINT, TST: remove tempdir #2682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use the upstream `pytest` temporary file/path handling instead of using/maintaining our own * no residual test artifacts were observed when the full test suite passed locally for this feature branch
Codecov Report
@@ Coverage Diff @@
## develop #2682 +/- ##
===========================================
+ Coverage 91.11% 91.12% +0.01%
===========================================
Files 175 175
Lines 23642 23642
Branches 3090 3090
===========================================
+ Hits 21541 21544 +3
+ Misses 1482 1480 -2
+ Partials 619 618 -1
Continue to review full report at Codecov.
|
orbeckst
approved these changes
May 15, 2020
|
Net decrease in code are good! Thanks @tylerjereddy ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2681
Changes made in this Pull Request:
use the upstream
pytesttemporary file/path handlinginstead of using/maintaining our own
no residual test artifacts were observed when the full
test suite passed locally for this feature branch
PR Checklist