update massive star test suites #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It might be helpful to rename |
|
@evbauer @fxt44 After this last commit is tested, I think this branch will be ready for a merge. I added an entry into the changelog, although I was curious if it was necessary or not? We have no entry on the re-addition of v_drag or the make_13bvn_test_case. I'm not sure what qualifies as a changelog worth change. |
|
adding to changelog seems best. "small ones", however defined, could be clipped for a wider distribution as part of a release candidate. |
|
Testing looks good! I think we're ready to go ahead and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #597, I have updated
12Msun_pms_to_cc, 20Msun_pms_to_cc, zams_to_cc_80, and make_pre_ccsn_13bvn.
All should run smoother. The 12 Msun should take roughly half the time.
The 20 and 80 Msun are now solar metallicity and their surfaces are at tau = 1.
I have added a run_all script for users who would like to photo restart instead of .mod restart.