Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update massive star test suites #613

Merged
merged 14 commits into from
Jan 25, 2024
Merged

update massive star test suites #613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
efc7f1d
rev1 update 20Msun test_suite
Debraheem Dec 18, 2023
35628fd
[ci skip] fix readme
Debraheem Dec 18, 2023
60535bf
[ci skip] tweaks
Debraheem Dec 18, 2023
0c21043
update 12,20,80 test suites
Debraheem Dec 19, 2023
ed05379
tweak 20 Msun and fix 80 Msun
Debraheem Dec 24, 2023
dadf3c8
update and tweak 13BVN
Debraheem Dec 24, 2023
bb619bb
full test, fix checksum: reduce photo interval
Debraheem Dec 27, 2023
16b3b20
[ci skip] rename rn_fxt and re_fxt
Debraheem Dec 27, 2023
3955a66
rework 13bvn again and remake .mod files
Debraheem Dec 28, 2023
c9ff9db
fix_photo_checksum don't relax split burn
Debraheem Dec 31, 2023
4517eef
turn off radiative damping in tdc, update changelog
Debraheem Jan 23, 2024
876824e
Merge remote-tracking branch 'origin' into EbF/update_massive_star_te…
Debraheem Jan 23, 2024
6f55ee3
[ci optional], tweak changelog, do full test
Debraheem Jan 23, 2024
4a5c184
clean up
Debraheem Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ gyre/ @rhdtownsend @warrickball
hdfio5 @rhdtownsend
interp_1d/ @rhdtownsend
interp_2d/ @rhdtownsend
kap/ @fxt44
kap/ @fxt44 @Debraheem
linters/
turb/
math/ @rhdtownsend
Expand Down Expand Up @@ -88,6 +88,7 @@ star/test_suite/make_he_wd @evbauer @fxt44
star/test_suite/make_metals @fxt44
star/test_suite/make_o_ne_wd @fxt44 @evbauer
star/test_suite/make_planets @fxt44
star/test_suite/make_pre_ccsn_13bvn @Debraheem
star/test_suite/make_sdb @evbauer
star/test_suite/make_zams @fxt44
star/test_suite/make_zams_low_mass @fxt44
Expand Down Expand Up @@ -126,11 +127,11 @@ star/test_suite/wd_he_shell_ignition @wmwolf
star/test_suite/wd_nova_burst @wmwolf
star/test_suite/wd_stable_h_burn @wmwolf

star/test_suite/12M_pre_ms_to_core_collapse
star/test_suite/20M_pre_ms_to_core_collapse
star/test_suite/split_burn_big_net
star/test_suite/zams_to_cc_80
star/test_suite/20M_z2m2_high_rotation
star/test_suite/12M_pre_ms_to_core_collapse @Debraheem
star/test_suite/20M_pre_ms_to_core_collapse @Debraheem
star/test_suite/split_burn_big_net
star/test_suite/zams_to_cc_80 @Debraheem
star/test_suite/20M_z2m2_high_rotation


binary/test_suite/double_bh @orlox
Expand Down
16 changes: 14 additions & 2 deletions docs/source/changelog.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,10 +87,22 @@ section (see documentation at :ref:`reference/controls:phase_separation_option`)
The phase diagram for O/Ne separation comes from
`Blouin & Daligault (2021b) <https://ui.adsabs.harvard.edu/abs/2021ApJ...919...87B/abstract>`_.

Massive Star test_suite Updates
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

The ``12Msun_pre_ms_to_core_collapse``, ``20Msun_pre_ms_to_core_collapse``, and ``zams_to_cc_80``
test_suites have each been updated and now fully evolve models at solar metallicities to core
collapse while keeping their surface boundaries at tau = 1. The models offer a framework which
has been tested to function with large reaction networks containing > 200 isotopes thanks to
'op_split_burn'. This updates includes the revival of the ``make_pre_ccsn_13bvn`` test_suite
as seen in section 6.9 of MESA IV.


.. _Bug Fixes main:

Bug Fixes
---------

The ZAMS model data used to generate the initial model for simulations with
``create_pre_main_sequence_model = .false.`` and ``load_saved_model = .false.``
had an issue where stars between 1.0 and 1.58 Msun would have a starting
Expand All @@ -100,8 +112,8 @@ and now all pre-computed ZAMS models have a central hydrogen mass fraction very
near 0.697.

The ``fixed_Teff``, ``fixed_Tsurf``, ``fixed_Psurf``, and ``fixed_Psurf_and_Tsurf``
atmosphere options have been reimplemented, although we caution users that their
implementation might conflict with mlt_option = ``TDC``.
atmosphere options were removed in r15140. We have reimplemented them although we
caution users that their implementation could conflict with ``mlt_option = 'TDC'``.

Changes in r23.05.1
===================
Expand Down
4 changes: 2 additions & 2 deletions star/test_suite/12M_pre_ms_to_core_collapse/README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@ This test case has six parts.

* Part 4 (``inlist_to_end_core_c_burn``) takes the model to core carbon depletion.

* Part 5 (``inlist_to_lgTmax``) evolves the model until the core temperature reaches log T =9.55 (approximately silicon burning)
* Part 5 (``inlist_to_lgTmax``) evolves the model until the core temperature reaches log T =9.60 (approximately silicon burning)

* Part 6 (``inlist_to_cc``) evolves until core collapse.


Last-Updated: 04Aug2023 by EbF
Last-Updated: 18Dec2023 by EbF

6 changes: 3 additions & 3 deletions star/test_suite/12M_pre_ms_to_core_collapse/history_columns.list
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,9 +249,9 @@
!log_extra_L ! log10 extra_L

!## neutrino losses
!log_Lneu ! log10 power emitted in neutrinos, nuclear and thermal (in Lsun units)
!log_Lneu_nuc ! log10 power emitted in neutrinos, nuclear sources only (in Lsun units)
!log_Lneu_nonnuc ! log10 power emitted in neutrinos, thermal sources only (in Lsun units)
log_Lneu ! log10 power emitted in neutrinos, nuclear and thermal (in Lsun units)
log_Lneu_nuc ! log10 power emitted in neutrinos, nuclear sources only (in Lsun units)
log_Lneu_nonnuc ! log10 power emitted in neutrinos, thermal sources only (in Lsun units)

!mass_loc_of_max_eps_nuc ! (in Msun units)
!mass_ext_to_max_eps_nuc ! (in Msun units)
Expand Down
Loading
Loading