Fix bug in nametag bug fix #1336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent bugfix in the playertag mod used a function object:get_parent() which did not exist. This changes it to use an equivilent that does exist.
|
Interesting, I put this on the main server immediately after pushing. No crashes yet. Thanks for the PR |
|
You're welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent commit, "Attempt to fix nametag bug", commit id bff7fd0, introduced a bug which is fixed here.
The commit added some code to mods/other/playertag/init.lua, and in the code was a call to self.object:get_parent().
This function does not exist, and therefore the server would crash after the end of each match when it tried to call it.
This PR replaces self.object:get_parent() with an equivalent self.object:get_attach().
Since self.object:get_attach() works slightly differently than how self.object:get_parent() was supposed to work, a bit more code is added in to compensate.