-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The version of get_distutils_platform here differs from the one in multibuild #2
Comments
Do you have any thoughts how best to fix this? |
Once choice would be to change the implementation, another would be to rename it here. Do you know if there are users of this repo other than openblas-libs ? |
Numpy-wheels and scipy-wheels use this repo - no? |
They seem to use The call to BUT: this version is not aware of the 64 bit builds (openblas64-v0.3* ) which are added after the call to |
multibuild has a stripped-down version of this repo in |
or would you prefer adding |
I'd prefer to avoid the situation where every user of multibuild pulls in the gfortran binaries. So - it's OK to move the code to multibuild, but maybe some on-the-fly way to get the gfortran binaries. But - even then - it seems the we're spreading the hack around, which I'd rather avoid. What do you think? |
We have four ways to get the openblas library name. One here, which is used in numpy-wheels and scipy-wheels to download before calling build_bdist_wheel from multibuild, but only for non-windows. In openblas-libs/appveyor/build_openblas.sh and openblas-libs/travis-ci/build_steps.sh the names are the ones used for uploading. The travis-ci/build_steps.sh uses this repo to get most of the name for CI for numpy uses numpy/tools/openblas_support.py, which I created to improve the hard-coded names scattered in the CI files CI for scipy uses hard-coded names in My choice would be to make everyone use the same code. How do we get there? Are there other users of the openblas libraries? |
MRG: allow more platforms, add unique function name xref gh-2 Add more platforms to the original version of `get_distutils_platform` Also add another function that is unique to this repo, which extends the original function for the manylinux version. In time, we should - convert downstream users `MacPython/openblas-libs` and the various `MacPython/*-wheels` to the new function - deprecate `get_distutils_platform`
Sorry - where are we with this one? |
Next up: make openblas-libs use the new function here. Then we need to think about how to get the download name to the wheel builders. I think I prefer the python solution in numpy/tools/openblas_support since it supports windows as well, where a bash shell script will not. |
Apparently this is the root cause for needing #5 |
Two versions of get_distutils_platform exist: the one here and the one in
multibuild/common_utils.sh
. The one here does not handle other architectures (s390x, ppc64le, aarch64).The text was updated successfully, but these errors were encountered: