BUG: allow more platforms, add unique function name #3
Conversation
|
CI is failing for Erlang. Is it supposed to pass? |
|
I was only using Erlang because, in the old days, it was the language Travis-CI suggested for a language-agnostic application. Any other is OK. |
|
tests are passing |
|
@matthew-brett ping |
gfortran_utils.sh
Outdated
| # Modify fat architecture tags on macOS to reflect compiled architecture | ||
| # For non-darwin, report manylinux version | ||
| local plat=$1 | ||
| local MB_ML_VER=${MB_ML_VER:-1} |
There was a problem hiding this comment.
avoid local names in all caps?
| @@ -29,6 +29,32 @@ function get_distutils_platform { | |||
| echo "macosx_${target}_${plat}" | |||
| } | |||
|
|
|||
| function get_distutils_platform_ex { | |||
There was a problem hiding this comment.
Where do you use this function?
There was a problem hiding this comment.
Can you write some tests for the function?
There was a problem hiding this comment.
used new function, added tests for old (to be deprecated) function
|
new tests are passing |
|
Just checking - but is the plan that, in due course, you will change the |
|
It already should accept other platforms (the old function as well) |
|
Ah sorry - read through the semicolons. |
xref gh-2
Add more platforms to the original version of
get_distutils_platformAlso add another function that is unique to this repo, which extends the original function for the manylinux version. In time, we should
MacPython/openblas-libsand the variousMacPython/*-wheelsto the new functionget_distutils_platform