Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing with ruby 3.2, 3.3 #870

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Testing with ruby 3.2, 3.3 #870

merged 1 commit into from
Nov 5, 2024

Conversation

kbrock
Copy link
Member

@kbrock kbrock commented Sep 30, 2024

No description provided.

@@ -14,6 +14,8 @@ jobs:
ruby-version:
- '3.0'
- '3.1'
- '3.2'
- '3.3'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just offering my thoughts on the plugins and core... I think we should be supporting 3.0-3.3 in plugins until we drop 3.0 in the Gemfile. I don't think we need to test all of those versions in plugins/core as I think it's fine to test only 3.0, 3.1, and 3.3 with the intention of dropping 3.0 as soon as we have smoke tested appliances and pods with rebuilt rpms against 3.3.

Repositories that don't load the core application (aka not core and not a plugin/engine) can test as many rubies and rails versions as make sense based on their usage. Things tied somewhat to the core rails app without loading it should stray closer to the rails app's dependencies (pg ha admin, logical replication, etc.) while other gems that are completely independent should have their own ruby/rails dependencies (ancestry, default_value_for, optimist, etc.).

@miq-bot
Copy link
Member

miq-bot commented Nov 5, 2024

Checked commit kbrock@7f3d30b with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 👍

@kbrock kbrock mentioned this pull request Nov 5, 2024
78 tasks
@bdunne bdunne merged commit 5ef88e0 into ManageIQ:master Nov 5, 2024
4 checks passed
@bdunne bdunne assigned bdunne and unassigned jrafanie Nov 5, 2024
@kbrock kbrock deleted the ruby3.3 branch November 5, 2024 23:15
@Fryguy
Copy link
Member

Fryguy commented Nov 14, 2024

Backported to radjabov in commit a4b5064.

commit a4b50649d0d1365aad03a66e9afbc02e56e31467
Author: Brandon Dunne <[email protected]>
Date:   Tue Nov 5 16:49:20 2024 -0500

    Merge pull request #870 from kbrock/ruby3.3
    
    Testing with ruby 3.2, 3.3
    
    (cherry picked from commit 5ef88e007b56f5ec266adc223f2d1be0d965b80f)

Fryguy pushed a commit that referenced this pull request Nov 14, 2024
Testing with ruby 3.2, 3.3

(cherry picked from commit 5ef88e0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants