Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing with ruby 3.2, 3.3 #870

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Testing with ruby 3.2, 3.3 #870

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ jobs:
strategy:
matrix:
ruby-version:
- '3.0'
- '3.1'
- '3.3'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just offering my thoughts on the plugins and core... I think we should be supporting 3.0-3.3 in plugins until we drop 3.0 in the Gemfile. I don't think we need to test all of those versions in plugins/core as I think it's fine to test only 3.0, 3.1, and 3.3 with the intention of dropping 3.0 as soon as we have smoke tested appliances and pods with rebuilt rpms against 3.3.

Repositories that don't load the core application (aka not core and not a plugin/engine) can test as many rubies and rails versions as make sense based on their usage. Things tied somewhat to the core rails app without loading it should stray closer to the rails app's dependencies (pg ha admin, logical replication, etc.) while other gems that are completely independent should have their own ruby/rails dependencies (ancestry, default_value_for, optimist, etc.).

services:
postgres:
image: manageiq/postgresql:13
Expand Down Expand Up @@ -44,6 +44,6 @@ jobs:
- name: Run tests
run: bundle exec rake
- name: Report code coverage
if: ${{ github.ref == 'refs/heads/master' && matrix.ruby-version == '3.1' }}
if: ${{ github.ref == 'refs/heads/master' && matrix.ruby-version == '3.3' }}
continue-on-error: true
uses: paambaati/codeclimate-action@v9