Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ansible_tower_client gem dependency updated to 0.17 #107

Merged
merged 1 commit into from
Jul 27, 2018
Merged

ansible_tower_client gem dependency updated to 0.17 #107

merged 1 commit into from
Jul 27, 2018

Conversation

bzwei
Copy link
Contributor

@bzwei bzwei commented Jul 12, 2018 •
edited by jameswnl
Loading

@agrare
Copy link
Member

agrare commented Jul 12, 2018

@bzwei think you mean update to 0.16

@bzwei
Copy link
Contributor Author

bzwei commented Jul 12, 2018

@miq-bot add_label bug, gaprindashvili/yes

@bzwei bzwei changed the title ansible_tower_client gem dependency updated to 0.15 ansible_tower_client gem dependency updated to 0.16 Jul 12, 2018
@bzwei
Copy link
Contributor Author

bzwei commented Jul 12, 2018

@agrare corrected. thanks.

@agrare agrare requested a review from jameswnl July 12, 2018 19:35
@agrare
Copy link
Member

agrare commented Jul 12, 2018 •
edited
Loading

@jameswnl just looking at git log --oneline v0.15.0..v0.16.0 for ansible_tower_client; some serious stuff made it in to v0.16.0, can you review the changes (specifically 7037781 Merge pull request #108 from miha-plesko/add-credential-types and 0c8363b Merge pull request #107 from miha-plesko/switchable-api-version) to see if it is appropriate to backport to gaprindashvili?

jameswnl
jameswnl reviewed Jul 16, 2018
View reviewed changes
Copy link
Contributor

@jameswnl jameswnl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's technically ok to merge this even though we have 2 issues need to take care:

  1. Let's wait for Default API version to 1 ansible/ansible_tower_client_ruby#113
  2. Also need to consider API v1/v2 switch is not effective if base_url already dictates it ansible/ansible_tower_client_ruby#114

@bdunne can you take a look?

@jameswnl
Copy link
Contributor

In order to port to gaprindashvili, the related PRs in core repo for ansible/ansible_tower_client_ruby#110 would needed to be backported as well.

@JPrause
Copy link
Member

JPrause commented Jul 26, 2018

@miq-bot add_label blocker

@JPrause
Copy link
Member

JPrause commented Jul 26, 2018

@bzwei @jameswnl is there anything else needed before this can be merged?

@bzwei
Copy link
Contributor Author

bzwei commented Jul 26, 2018

@bdunne said he was working on it. @bdunne please update.

@bdunne
Copy link
Member

bdunne commented Jul 27, 2018

ansible_tower_client v0.17.0 has been released with the v2 api changes reverted.

@bzwei bzwei changed the title ansible_tower_client gem dependency updated to 0.16 ansible_tower_client gem dependency updated to 0.17 Jul 27, 2018
@bzwei
Copy link
Contributor Author

bzwei commented Jul 27, 2018

@bdunne bump to 0.17 now

bdunne
bdunne approved these changes Jul 27, 2018
View reviewed changes
Copy link
Member

@bdunne bdunne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@miq-bot
Copy link
Member

miq-bot commented Jul 27, 2018

Checked commit bzwei@12b7b48 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@jameswnl jameswnl merged commit d2598da into ManageIQ:master Jul 27, 2018
@bronaghs bronaghs added this to the Sprint 91 Ending Jul 30, 2018 milestone Jul 30, 2018
@simaishi
Copy link
Contributor

@bzwei @jameswnl Gaprindashvili branch is currently using 0.13.0. Please confirm updating from 0.13.0 to 0.17.0 is ok.

@jameswnl
Copy link
Contributor

jameswnl commented Aug 1, 2018

@simaishi yes, it should be ok

@simaishi
Copy link
Contributor

simaishi commented Aug 6, 2018

Gaprindashvili backport (to manageiq repo) details:

$ git log -1
commit 274821b23d5563b97e81790f9e6cc1e779eae39a
Author: James Wong <[email protected]>
Date:   Fri Jul 27 18:28:50 2018 -0400

    Merge pull request #107 from bzwei/gem_16
    
    ansible_tower_client gem dependency updated to 0.17
    (cherry picked from commit d2598daab4411743540c951e9a4eb88d743c096a)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1599350

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameswnl jameswnl jameswnl left review comments

@bdunne bdunne bdunne approved these changes

Assignees
No one assigned
Labels
blocker bug gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@bzwei @agrare @jameswnl @JPrause @bdunne @miq-bot @simaishi @bronaghs