Skip to content
This repository has been archived by the owner on May 23, 2024. It is now read-only.

Set the faraday logger when creating connection #110

Merged
merged 1 commit into from
Jul 3, 2018

Conversation

agrare
Copy link
Contributor

@agrare agrare commented Jun 25, 2018

Set the faraday response logger when creating a new Faraday object.
Allow the logger to be set as an option to the AnsibleTowerClient::Connection or fall back to the AnsibleTowerClient.logger.

@agrare
Copy link
Contributor Author

agrare commented Jun 25, 2018

@miq-bot assign @Fryguy

@agrare agrare force-pushed the set_faraday_response_logger branch from aa81ed5 to 7baac79 Compare June 25, 2018 20:38
Set the faraday response logger when creating a new Faraday object.
Allow the logger to be set as an option to the
AnsibleTowerClient::Connection or fall back to the
AnsibleTowerClient.logger.
@agrare agrare force-pushed the set_faraday_response_logger branch from 7baac79 to 346b6a7 Compare June 26, 2018 13:08
@miq-bot
Copy link
Collaborator

miq-bot commented Jun 26, 2018

Checked commit agrare@346b6a7 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 👍

@Fryguy
Copy link
Contributor

Fryguy commented Jun 27, 2018

LGTM @syncrou ?

@Fryguy Fryguy assigned bdunne and unassigned Fryguy Jun 27, 2018
Copy link
Contributor

@syncrou syncrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@bdunne bdunne merged commit a6f71ac into ansible:master Jul 3, 2018
@agrare agrare deleted the set_faraday_response_logger branch July 3, 2018 17:20
@JPrause
Copy link

JPrause commented Jul 26, 2018

@miq-bot add_label blocker

@miq-bot
Copy link
Collaborator

miq-bot commented Jul 26, 2018

@JPrause Cannot apply the following label because they are not recognized: blocker

@JPrause
Copy link

JPrause commented Jul 26, 2018

@bdunne if this can be backported, can you add the gaprindashvili/yes label

@bdunne
Copy link
Contributor

bdunne commented Jul 26, 2018

@JPrause those labels don't apply to this gem. The consumer would have to pull in the version that fixes their bug.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants